Skip to content

feat(icon): prototype custom icon support via path definition #12749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft

feat(icon): prototype custom icon support via path definition #12749

wants to merge 4 commits into from

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Aug 21, 2025 •
edited
Loading

Related Issue: #4803

Summary

⚠️Prototype⚠️

Enhances the icon prop to support custom icons by:

  1. Passing an SVG path using the existing scale (icon="<path>"):

    <calcite-icon icon="M2.4 7.2 a4.8 4.8 0 0 1 9.6 0 a4.8 4.8 0 0 1 9.6 0 q0 7.2-9.6 14.4 q-9.6-7.2-9.6-14.4z" />

  2. Optionally adding a custom viewBox (icon="<path>|<viewBox>"):

    <calcite-icon icon="M10 30a20 20 0 0 1 40 0 20 20 0 0 1 40 0q0 30-40 60-40-30-40-60z|0 0 100 100" />

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Aug 21, 2025
@jcfranco jcfranco changed the title feat(icon): prototype data attribute support feat(icon): prototype custom icon support via path definition Aug 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Aug 29, 2025
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Sep 5, 2025
@jcfranco jcfranco mentioned this pull request Sep 5, 2025
Open
@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Sep 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Sep 16, 2025
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Sep 19, 2025
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Sep 19, 2025
@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Sep 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jcfranco jcfranco

Labels

enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing. Stale Issues or pull requests that have not had recent activity.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jcfranco