-
Notifications
You must be signed in to change notification settings - Fork 80
feat(tailwind): switch text utils to use line-height token CSS props #12842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊
🌊🌊🚢🚢🚢🌊🚢🌊🌊🚢🌊🚢🚢🚢🌊🚢🚢🚢🌊🌊🌊🌊🚢🚢🚢🌊🚢🚢🚢🚢🚢🌊🚢🌊
🌊🚢🌊🌊🌊🌊🚢🌊🌊🚢🌊🌊🚢🌊🌊🚢🌊🌊🚢🌊🌊🌊🌊🚢🌊🌊🌊🌊🚢🌊🌊🌊🚢🌊
🌊🌊🚢🚢🌊🌊🚢🚢🚢🚢🌊🌊🚢🌊🌊🚢🚢🚢🌊🌊🌊🌊🌊🚢🌊🌊🌊🌊🚢🌊🌊🌊🚢🌊
🌊🌊🌊🌊🚢🌊🚢🌊🌊🚢🌊🌊🚢🌊🌊🚢🌊🌊🌊🌊🌊🌊🌊🚢🌊🌊🌊🌊🚢🌊🌊🌊🌊🌊
🌊🚢🚢🚢🌊🌊🚢🌊🌊🚢🌊🚢🚢🚢🌊🚢🌊🌊🌊🌊🌊🌊🚢🚢🚢🌊🌊🌊🚢🌊🌊🌊🚢🌊
🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊🌊
@matgalla FYI, I updated the PR title for clarity. |
Belated update: @matgalla pointed out a screen diff issue after we updated the Tailwind text utilities’ line-height values from relative units (rem) to fixed units (px). I think the |
Yeah, |
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
Related Issue: #11555
Summary
Converts raw values to semantic line-height tokens for the following:
Fixed line-heights:
n3h: [new semantic token]
n2h: [new semantic token]
n1h: [new semantic token]
0h: [new semantic token]
1h: [new semantic token]
2h: [new semantic token]
3h: [new semantic token]
4h: [new semantic token]
5h: [new semantic token]
6h: [new semantic token]
7h: [new semantic token]
8h: [new semantic token]
Relative line-heights
n3-wrap:
--calcite-font-line-height-relative-snug
n2-wrap:
--calcite-font-line-height-relative-snug
n1-wrap:
--calcite-font-line-height-relative-snug
0-wrap:
...-snug
1-wrap:
...-snug
2-wrap:
...-snug
3-wrap:
...-tight
4-wrap:
...-tight
5-wrap:
...-tight
6-wrap:
...-tight
7-wrap:
...-tight
8-wrap:
...-tight