Skip to content

Conversation

@Elijbet
Copy link
Contributor

@Elijbet Elijbet commented Nov 6, 2025

Related Issue: #10568

Summary

Prototype: Standardize and expose the existing internal pattern as a public updateSize(size, axis) method backed by a shared useSizeOverride controller. Preserve one‑way token semantics, enable explicit reversible runtime sizing, reduce duplication, and clarify when to choose tokens vs imperative overrides.

Tests: Migrate vertical/horizontal resize E2E to browser mode; add isolated controller spec.
Docs: Added JSDoc (when to use vs tokens).

@Elijbet Elijbet changed the title Add useSizeOverride controller and spec feat: add useSizeOverride controller and spec Nov 6, 2025
… other controllers. Fixed lazy targetElement access, numeric min/max clamping, and internal state updates. Updated ShellPanel to use the controller Reworked browser specs to call sizeOverride.apply() and added guards.
@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Nov 12, 2025
@Elijbet Elijbet changed the title feat: add useSizeOverride controller and spec feat(shell-panel): add public updateSize API backed by useSizeOverride controller Nov 14, 2025
@Elijbet Elijbet marked this pull request as ready for review November 14, 2025 23:47
@jcfranco
Copy link
Member

@Elijbet Can you confirm whether this is still a prototype or the feature intended to land? If it’s the latter, can you update the description to reflect this? Also, can you revisit the title to focus on the feature itself (i.e., no need to call out useSizeOverride as this is an implementation detail that can be covered in the PR description or the commit itself).

@Elijbet
Copy link
Contributor Author

Elijbet commented Nov 17, 2025

@Elijbet Can you confirm whether this is still a prototype or the feature intended to land? If it’s the latter, can you update the description to reflect this? Also, can you revisit the title to focus on the feature itself (i.e., no need to call out useSizeOverride as this is an implementation detail that can be covered in the PR description or the commit itself).

This is still a prototype - I want to get feedback from the team on whether this approach makes sense before finalizing it. Once we confirm the approach and I address any feedback, I'll update it to be merge-ready as the final feature.

@Elijbet Elijbet changed the title feat(shell-panel): add public updateSize API backed by useSizeOverride controller feat(shell-panel): add size override capability Nov 17, 2025
@Elijbet Elijbet requested a review from jcfranco November 17, 2025 23:02
@Elijbet Elijbet marked this pull request as draft December 1, 2025 23:15
@Elijbet Elijbet marked this pull request as ready for review December 3, 2025 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Issues tied to a new feature or request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants