-
Notifications
You must be signed in to change notification settings - Fork 80
feat(shell-panel): add size override capability #13280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…dates after user resize
This reverts commit 48a32a6.
…-of-resizable-panel
…lling interaction APIs, drop describe block and wrapper for test case
… in a similar fashion
…-of-resizable-panel
… other controllers. Fixed lazy targetElement access, numeric min/max clamping, and internal state updates. Updated ShellPanel to use the controller Reworked browser specs to call sizeOverride.apply() and added guards.
…e, update the controller spec test to use a fake component wrapper
updateSize API backed by useSizeOverride controller
|
@Elijbet Can you confirm whether this is still a prototype or the feature intended to land? If it’s the latter, can you update the description to reflect this? Also, can you revisit the title to focus on the feature itself (i.e., no need to call out |
This is still a prototype - I want to get feedback from the team on whether this approach makes sense before finalizing it. Once we confirm the approach and I address any feedback, I'll update it to be merge-ready as the final feature. |
updateSize API backed by useSizeOverride controller…mock known Lit nested menu warn so failOnConsole doesn’t fail
…nd remove call out to design tokens in the controller doc
…keyboard and mouse, combine min and max into getBounds
…o avoid readonly index errors, missing async, etc
… - test for returned value instead, arrowKey to sync resizeValues
Related Issue: #10568
Summary
Prototype: Standardize and expose the existing internal pattern as a public
updateSize(size, axis)method backed by a shareduseSizeOverridecontroller. Preserve one‑way token semantics, enable explicit reversible runtime sizing, reduce duplication, and clarify when to choose tokens vs imperative overrides.Tests: Migrate vertical/horizontal resize E2E to browser mode; add isolated controller spec.
Docs: Added JSDoc (when to use vs tokens).