Skip to content

Fix default Minecraft join message not being used #5848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from
Open

Fix default Minecraft join message not being used #5848

wants to merge 2 commits into from

Conversation

zp4rker
Copy link

@zp4rker zp4rker commented Jun 27, 2024

Information

This PR fixes #5796.

Details

Proposed fix:

  • Add permission check for essentials.silentjoin/essentials.silentjoin.vanish
  • Remove broadcast of join message when allowSilentJoinQuit() is true

Environments tested:

OS: Windows 11

Java version: Corretto-21.0.3.9.1

  • Most recent Paper version (1.20.6-147-ver/1.20.6@e41d44f)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8

Demonstration:

image

zp4rker added 2 commits June 27, 2024 23:17
@zp4rker
Fix default Minecraft join message not being used
47ed96e 
Default Minecraft join message not used when allow-silent-join-quit set to true
Remove unnecessary broadcast of join message since default join message is working again

Fixes EssentialsX#5796
@zp4rker
Merge branch '2.x' into fix_locale_join_message
f5aa875
JRoy
JRoy requested changes Mar 24, 2025
View reviewed changes
Copy link
Member

@JRoy JRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a chance that the User is not fully loaded during this point of the event, you should probably just perform the permission check on the Bukkit player object rather than the User object

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JRoy JRoy JRoy requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minecraft default join message is not translated
2 participants
@zp4rker @JRoy