feat(transmission): add transmisson downloader and model #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Owner
Author
|
transmission是rpc实现的，我认为将函数修改为异步即可，应该不需要用httpx实现？ BaseDownloader本意是作为一个基类，不过我看在 #567 已经做了修改（删除了很多未使用的方法），只留下了必要的方法。目前我认为应该不需要做额外处理，谢谢. |
Owner
是的，辛苦啦～ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
仿照QB下载器的形式利用transmission-rpc 完成了基本的功能，其中QBDownloader的部分功能并未使用，在tr中也就没有实现。
可能未来做一个BaseDownloader来管理更多的下载器会更好？如果有需要我可以提一个RFC并在后续版本完成他。