Replace CKEditor by TinyMCE in Pod V4 #1227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade securtity dependances * Remove deprecated django-tagging * Add new django-tagulous * Elasticsearch default version is Now 8 (remove compatibility with ES 6) * Replace deprecated ugettext_lazy by gettext_lazy * Add some temporary deprecations Hacks for cas-client & Chunked-upload * Replace deprecated url() by re_path() * Disable all Pods apps by default * Correct error handling for ElasticSearch
# Conflicts: # pod/settings.py
* Replace some re_path() by path()
* Replace remaining ugettext by gettext
* Replace admin.site.register() call by @admin.register decorator
* Replace HTTP_X_REQUESTED_WITH by `headers={"x-requested-with"`
* Replace request.META by headers
* Replace `assertQuerysetEqual` by `assertQuerySetEqual`
* Replace force_text by force_str
* Remove default_app_config in __init__.py
…select2 CSS calls) * Correct Enrichment form validation process
* Replace Django 3.2 by 4.2 in all links
# Conflicts: # pod/settings.py
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ionalError: database table is locked"
# Conflicts: # requirements.txt
…bug preventing not encoded video to be edited)
Badatos
changed the title
Correct CVE-2024-56374: Potential denial-of-service vulnerability in IPv6 validation
# Conflicts: # .env.dev-exemple # dockerfile-dev-with-volumes/README.adoc # pod/main/test_settings.py # pod/video/models.py # pod/video/utils.py # requirements.txt
# Conflicts: # requirements.txt
LoicBonavent
approved these changes
Jan 31, 2025
Collaborator
LoicBonavent
left a comment
LoicBonavent
left a comment
There was a problem hiding this comment.
Sur le coup, je ne l'ai pas testé, mais cela me semble nickel !
J'ai vu que la problématique de mise à jour d'un champ textarea est géré (de souvenir, c'était le seul point tricky avec CKEditor), donc GJ :)
# Conflicts: # .github/workflows/pod_dev.yml # pod/urls.py # pod/video/admin.py # pod/video/models.py # requirements.txt
gcondess
approved these changes
Mar 11, 2025
Collaborator
gcondess
left a comment
gcondess
left a comment
There was a problem hiding this comment.
Je ne maitrise pas trop tout ce qui est fait dans "pod/main/static/js/main.js" (mais je fait confiance à Olivier;)
Sinon j'ai installée la PR localement pour tester le plugin sur les pages d'édition des vidéo et d'administration des chaines sans rencontrer de problème. La mise en forme et l'enregistrement fonctionne bien
En plus je trouve que cette implémentation de Tiny est moins envahissante de celle de CKEditor (ou il y avait beaucoup trop de boutons à mon gout :)
pod/main/static/js/main.js
Outdated
| * @param {[type]} elem [description] | ||
| * Hide element whith fade effect | ||
| * @param {HTMLElement} elem Dom element to hide | ||
| * @param {[type]} speed [description] |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in django-ckeditor latest version:
... So this PR try to replace it by TinyMCE