Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CKEditor by TinyMCE in Pod V4 #1227

Open
wants to merge 74 commits into
base: main
Choose a base branch
from
Open

Replace CKEditor by TinyMCE in Pod V4 #1227

wants to merge 74 commits into from

Conversation

Badatos
Copy link
Collaborator

@Badatos Badatos commented Nov 13, 2024

As seen in django-ckeditor latest version:

WARNING (ckeditor.W001) django-ckeditor bundles CKEditor 4.22.1 free version, which isn’t supported anmyore and which does have unfixed security issues.
See for example https://ckeditor.com/cke4/release/CKEditor-4.24.0-LTS .
You should consider strongly switching to a different editor.

... So this PR try to replace it by TinyMCE

Badatos and others added 14 commits October 24, 2024 12:10
* Upgrade securtity dependances
* Remove deprecated django-tagging
* Add new django-tagulous
* Elasticsearch default version is Now 8 (remove compatibility with ES 6)
* Replace deprecated ugettext_lazy by gettext_lazy
* Add some temporary deprecations Hacks for cas-client & Chunked-upload
* Replace deprecated url() by re_path()
* Disable all Pods apps by default
* Correct error handling for ElasticSearch
# Conflicts:
#	pod/settings.py
* Replace some re_path() by path()
* Replace remaining ugettext by gettext
* Replace admin.site.register() call by @admin.register decorator
* Replace HTTP_X_REQUESTED_WITH by `headers={"x-requested-with"`
* Replace request.META by headers
* Replace `assertQuerysetEqual` by `assertQuerySetEqual`
* Replace force_text by force_str
* Remove default_app_config in __init__.py
…select2 CSS calls)

* Correct Enrichment form validation process
* Replace Django 3.2 by 4.2 in all links
# Conflicts:
#	pod/settings.py
@Badatos Badatos changed the base branch from master to pod_V4 November 13, 2024 16:22
@Badatos Badatos self-assigned this Nov 13, 2024
@Badatos Badatos marked this pull request as ready for review December 12, 2024 15:33
@Badatos Badatos changed the title [WIP] Replace CKEditor by TinyMCE in Pod V4 Replace CKEditor by TinyMCE in Pod V4 Dec 12, 2024
Correct CVE-2024-56374: Potential denial-of-service vulnerability in IPv6 validation
# Conflicts:
#	.env.dev-exemple
#	dockerfile-dev-with-volumes/README.adoc
#	pod/main/test_settings.py
#	pod/video/models.py
#	pod/video/utils.py
#	requirements.txt
# Conflicts:
#	requirements.txt
@LoicBonavent LoicBonavent self-requested a review January 31, 2025 14:59
Copy link
Collaborator

@LoicBonavent LoicBonavent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sur le coup, je ne l'ai pas testé, mais cela me semble nickel !
J'ai vu que la problématique de mise à jour d'un champ textarea est géré (de souvenir, c'était le seul point tricky avec CKEditor), donc GJ :)

@Badatos Badatos changed the base branch from pod_V4 to main February 7, 2025 10:58
# Conflicts:
#	.github/workflows/pod_dev.yml
#	pod/urls.py
#	pod/video/admin.py
#	pod/video/models.py
#	requirements.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants