-
Notifications
You must be signed in to change notification settings - Fork 79
[Init] Initialization of the POD_V5 project (Backend) #1392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev_v5
Are you sure you want to change the base?
Conversation
… COPYING, SECURITY) and remove obsolete configuration files (nginx.conf, uwsgi.ini)
Update llms.txt to reference consolidated dev.md. Add test_scenarios.py for authentication mode testing.
|
Bonjour Benjamin, |
|
@Benjamin-etu-lille je t'invite à lancer la commande suivante : Sur la v4, c'est fait automatiquement dans ce workflow : |
Badatos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Voila déja une première vague de commentaires.
La suite la semaine pro ;)
| | :--- | :---: | :--- | :--- | | ||
| | **`DJANGO_SETTINGS_MODULE`** | ✅ | `config.django.base` | Python path to settings module. (e.g. `config.django.dev.docker`) | | ||
| | **`SECRET_KEY`** | ✅ | *(None)* | Django security key. **Must be secret in production.** | | ||
| | **`VERSION`** | ❌ | `5.0.0-DEV` | Application version tag. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pourquoi placer le numéro de version en variable d'environnement ?
A priori, c'est le code qui définit la version, et non la config. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est pour que la version soit synchronisée avec la CI/CD et l'ensemble des services (DB et API). Cela évite de devoir faire un commit juste pour changer la version, et on peut même configurer la CI/CD pour qu'elle crée automatiquement les tags en cas de changement de version majeur.
POD_V5 Project Initialization
This Pull Request corresponds to the very first building block of the POD_V5 project.
It initializes the technical base and lays the foundations of the new backend architecture.
Particular care has been taken with:
Objectives of this PR
Setup of the Django project structure
Initial configuration:
Addition of basic and technical documentation
Initialization of:
Priority review points
As this PR constitutes the base of the project, all feedback is expected, especially regarding:
Documentation
Detailed documentation accompanies this initialization:
README.mdat the rootdocs/directoryImplemented Endpoint
Checklist avant review
https://github.com/EsupPortail/Esup-Pod/blob/master/CONTRIBUTING.md
dev_v4draftsi elle est encore en cours de construction