Skip to content

[WIP] Hide video player when video is in encoding #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CartierPierre wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[WIP] Hide video player when video is in encoding #893

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pod/video/templates/videos/video.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,11 @@ <h4 class="accordion-header theme_title" id="theme_desc_title">
{% if form %}
{% include 'videos/video-form.html' %}
{% else %}
{% include 'videos/video-element.html' %}
{% if video.get_encoding_step == "" or video.encoding_in_progress %}
Copy link
Contributor

@ptitloup ptitloup Jun 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

il y a la propriété encoded qui pourrait egalement servir : https://github.com/EsupPortail/Esup-Pod/blob/master/pod/video/models.py#L1000
Et, ne faudrait-il pas egalement ne pas charger les différents scripts utilisé par le lecteur ? (pour eviter les pb js)

Copy link
Contributor

@ptitloup ptitloup Jun 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pourquoi ne pas faire un simple display : none ? (je réfléchi tout haut !)

Copy link
Contributor Author

@CartierPierre CartierPierre Jun 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui c'est possible aussi, je suis pas très bon coté JS, j'ai préféré intervenir directement dans le template. Est-ce pertinent de charger le player et de ne pas l'afficher pour les petites connexions ?

{% comment %} Hide player {% endcomment %}
{% else %}
{% include 'videos/video-element.html' %}
{% endif %}
<div id="info-video" class="pod-info-video">{% include 'videos/video-all-info.html' %}</div>
{% endif %}
{% endblock video-element %}
Expand Down