Skip to content

Improve OTP-push accessibility - Part 1 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Badatos
Copy link
Contributor

@Badatos Badatos commented Jan 29, 2025

Bonjour,
Voici une première PR pour améliorer l'accessibilité de l'application OTP Push / Esup Auth.
Elle est basée sur la branche "main" mais peut-être préférez-vous que je la base sur une autre branche ?
N'hésitez pas à préciser s'il y a d'autres règles de contribution à respecter.

Voici les détails des changements effectués :

  • Add lang attribute on html tag
  • Use H1 on page-title
  • Correct heading hierarchy (h5 > H2)
  • Add empty alt on every presentation icon
  • Add css styles for headings (H1,2,3..)
  • Improve contrast of label color
  • Remove redundant title tag

* Use H1 on page-title, and specify line-height
* Correct heading hierarchy (h5 > H2)
* Add empty alt on every presentation icon
* Add css styles for headings (H1,2,3..)
* Simplify some CSS colors
@aanli aanli assigned MpenielG and unassigned mbdeme Jan 29, 2025
@Badatos
Copy link
Contributor Author

Badatos commented Jan 30, 2025

Branche mise à jour avec main. Prête pour une relecture.

@mbdeme mbdeme requested a review from MpenielG January 31, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants