Convert project to Node.js v20 and many more updates ✨ #19
Open
Ethan-Arrowood wants to merge 2 commits intomainfrom
Open
Convert project to Node.js v20 and many more updates ✨ #19Ethan-Arrowood wants to merge 2 commits intomainfrom
Ethan-Arrowood wants to merge 2 commits intomainfrom
Conversation
jasnell
reviewed
Sep 5, 2024
| import { isSocketAddress } from './is-socket-address'; | ||
|
|
||
| export function connect( | ||
| import net from 'node:net' |
Collaborator
There was a problem hiding this comment.
Insert blanket preference for trailing semi-colons here.
#TeamSemicolonFTW
Owner
Author
There was a problem hiding this comment.
I switched to https://github.com/neostandard/neostandard , which does have a semi option. I'll enable it in a follow up 😉
jasnell
approved these changes
Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm finally able to maintain this project again so I spent some time tonight updating the project to Node.js v20 as well as updating all of the dev dependencies.
Summary of changes:
@vercel/style-guidetaptonode:testeslinttov9If we want to follow semver, we should make this v1. However, afaik its not uncommon to ignore semver while a module is pre-v1
I'll defer to the recommendation of the Cloudflare folks who may be depending on this module.