Skip to content

fix: bun install in build-wheel.yml #3932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 7, 2025
Merged

fix: bun install in build-wheel.yml #3932

merged 8 commits into from
Mar 7, 2025

Conversation

kevinzwang
Copy link
Member

@kevinzwang kevinzwang commented Mar 7, 2025

Also upgrades the manylinux version since Bun expects a higher glibc version than the one provided in the manylinux2014 container. This does remove support for certain ancient versions of linux but I'm not particularly concerned.

Built wheels are also expected to be compatible with other distros using glibc 2.28 or later, including:

  • Debian 10+
  • Ubuntu 18.10+
  • Fedora 29+
  • CentOS/RHEL 8+

https://github.com/pypa/manylinux

@github-actions github-actions bot added the fix label Mar 7, 2025
@kevinzwang
Copy link
Member Author

kevinzwang commented Mar 7, 2025

Waiting on this to succeed:
https://github.com/Eventual-Inc/Daft/actions/runs/13727476081

@kevinzwang kevinzwang requested a review from samster25 March 7, 2025 19:13
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.53%. Comparing base (2b765a7) to head (9e1e32f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3932      +/-   ##
==========================================
- Coverage   78.53%   78.53%   -0.01%     
==========================================
  Files         772      772              
  Lines       98315    98315              
==========================================
- Hits        77211    77210       -1     
- Misses      21104    21105       +1     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kevinzwang kevinzwang merged commit 5618f21 into main Mar 7, 2025
56 checks passed
@kevinzwang kevinzwang deleted the kevin/docker-bun branch March 7, 2025 22:20
kevinzwang added a commit that referenced this pull request Mar 8, 2025
Also upgrades the manylinux version since Bun expects a higher glibc
version than the one provided in the manylinux2014 container. This does
remove support for certain ancient versions of linux but I'm not
particularly concerned.

> Built wheels are also expected to be compatible with other distros
using glibc 2.28 or later, including:
> * Debian 10+
> * Ubuntu 18.10+
> * Fedora 29+
> * CentOS/RHEL 8+

https://github.com/pypa/manylinux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants