Skip to content

feat: add partition-by + order-by support for rank window functions #4078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 46 commits into
base: main
Choose a base branch
from
Draft

feat: add partition-by + order-by support for rank window functions #4078

wants to merge 46 commits into from

Conversation

f4t4nt
Copy link
Contributor

@f4t4nt f4t4nt commented Mar 26, 2025

Adds support for window functions with both partition-by and order-by clauses, starting with rank functions.

f4t4nt added 30 commits February 14, 2025 13:08
@f4t4nt
feat(window): add skeleton code for window functions and expressions
f4d2730
@f4t4nt
feat(window): implement window functions skeleton in rust
fc93093
@f4t4nt
feat(window): add window function bindings and expressions
7b7b380
@f4t4nt
feat(window): implement window function skeleton and update tests
4f5ba5c
@f4t4nt
feat(window): fix df.select in tests
0998d49
@f4t4nt
feat(window): implement window functions core and bindings
71c5fdc
@f4t4nt
test(window): retain only test_basic.py for window tests
1918fb8
@f4t4nt
fix(window): fix linter errors during window functions implementation
2173c13
@f4t4nt
fix(window): resolve logical plan errors in window functions implemen…
ea7197c 
…tation
@f4t4nt
feat(window): implement window functions support in logical plan
efa0223
@f4t4nt
feat(window): initial implementation of window functions
ffca1bb
@f4t4nt
feat(window): implement window functions and add test helper to ignor…
52e49c9 
…e row ordering
@f4t4nt
fix(window): skip hardcoded window test
bd5dcaf
@f4t4nt
fix(tests): correct pytest skip decorator in window tests
f7aa71d
@f4t4nt
refactor(window): remove unused window function code
435aa14
@f4t4nt
refactor(window): simplify naming convention for empty input window f…
ee2ba53 
…unctions
@f4t4nt
refactor(window): clarify min_periods comment
bd44148
@f4t4nt
feat(window): implement window partition only sink
407c7ec
@f4t4nt
refactor(window): remove non-agg window functions
dd58c15
@f4t4nt
refactor(window): rename DetectWindowFunction to ExtractWindowFunction
7dee0b5
@f4t4nt
refactor(window): remove unused WindowExpr struct
261ba6b
@f4t4nt
refactor(window): remove println debugging statements
40c51c0
@f4t4nt
refactor(logical-plan): undo changes to arguments in PushDownProjecti…
d2dcc40 
…on methods
@f4t4nt
refactor(logical-plan): use WindowSpec in Window struct instead of se…
cb0d889 
…parate fields
@f4t4nt
fix(unnest-subquery): move Window operator to non-pullable case
a7197ec
@f4t4nt
refactor(window): streamline WindowFrameBoundary with unified offset …
26a48ab 
…representation
@f4t4nt
refactor(window): make WindowSpec methods non-consuming
ee07b73
@f4t4nt
refactor(window): remove redundant WindowBoundary wrapper
678d380
@f4t4nt
fix(window): properly expose window boundary classes in Python
7ed367c
@f4t4nt
fix(window): Window -> WindowSpec in __init__.pyi
2d1ca94
f4t4nt added 16 commits March 18, 2025 16:12
@f4t4nt
refactor(window): some clean up of unused window functions ie lag/lead
0c3eec6
@f4t4nt
fix(window): implement join-based window partition aggregation
d0cab64
@f4t4nt
fix(window): implement initial optimization for partition-only window…
79c2ad1 
… functions
@f4t4nt
fix(window): use partition_by_value to avoid hash collisions in windo…
fa64285 
…w functions
@f4t4nt
fix(window): ensure deterministic partition keys for cross-platform c…
0cd6211 
…onsistency
@f4t4nt
fix(window): add debug logging for cross-platform partition issues
5832091
@f4t4nt
fix(window): replace logging with println for better cross-platform d…
37b3685 
…ebugging
@f4t4nt
fix(window): add debug prints to diagnose platform differences
f249599
@f4t4nt
fix(window): process all partitions together for consistent behavior …
eaa128c 
…across platforms
@f4t4nt
feat(window): implement parallel processing for window partition-only…
66d4e2f 
… operations
@f4t4nt
refactor(window): clean up window partition code and fix linter warnings
1714d09
@f4t4nt
fix(window): create unique names for multiple window functions
4fe92d1
@f4t4nt
test(window): skip window tests if not running with native runner
5302a05
@f4t4nt
test(window): rename test file to test_partition_only.py and add arit…
338d56a 
…hmetic window tests
@f4t4nt
test(window): add test specifications for order by window functions
2862cfc
@f4t4nt
feat(window): add initial support for order_by in window functions
5abf4f6
@github-actions github-actions bot added the feat label Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@f4t4nt