Skip to content

feat(window): dynamic window frame aggregations (sliding / running window functions) #4198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 127 commits into
base: main
Choose a base branch
from

Conversation

f4t4nt
Copy link
Contributor

@f4t4nt f4t4nt commented Apr 15, 2025

Add support for aggregations over sliding / running window functions

f4t4nt added 30 commits March 26, 2025 18:25
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 85.12397% with 72 lines in your changes missing coverage. Please review.

Project coverage is 78.53%. Comparing base (e99d8cc) to head (b4d072f).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...on/src/sinks/window_partition_and_dynamic_frame.rs 73.58% 42 Missing ⚠️
src/daft-recordbatch/src/ops/window.rs 88.88% 10 Missing ⚠️
src/daft-local-plan/src/translate.rs 86.27% 7 Missing ⚠️
src/daft-local-plan/src/plan.rs 85.29% 5 Missing ⚠️
...ecution/src/sinks/window_partition_and_order_by.rs 94.54% 3 Missing ⚠️
src/daft-local-execution/src/sinks/window_base.rs 95.55% 2 Missing ⚠️
...local-execution/src/sinks/window_partition_only.rs 84.61% 2 Missing ⚠️
src/daft-local-execution/src/pipeline.rs 96.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4198      +/-   ##
==========================================
+ Coverage   78.48%   78.53%   +0.04%     
==========================================
  Files         798      800       +2     
  Lines      105351   105702     +351     
==========================================
+ Hits        82686    83010     +324     
- Misses      22665    22692      +27     
Files with missing lines Coverage Δ
src/daft-dsl/src/expr/mod.rs 78.12% <100.00%> (+0.09%) ⬆️
src/daft-local-execution/src/pipeline.rs 89.75% <96.66%> (+0.40%) ⬆️
src/daft-local-execution/src/sinks/window_base.rs 95.55% <95.55%> (ø)
...local-execution/src/sinks/window_partition_only.rs 77.31% <84.61%> (-5.48%) ⬇️
...ecution/src/sinks/window_partition_and_order_by.rs 78.88% <94.54%> (-1.12%) ⬇️
src/daft-local-plan/src/plan.rs 93.36% <85.29%> (+0.20%) ⬆️
src/daft-local-plan/src/translate.rs 91.51% <86.27%> (+0.29%) ⬆️
src/daft-recordbatch/src/ops/window.rs 91.17% <88.88%> (-1.51%) ⬇️
...on/src/sinks/window_partition_and_dynamic_frame.rs 73.58% <73.58%> (ø)

... and 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@f4t4nt f4t4nt requested a review from kevinzwang April 18, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants