build: make dashboard self contained again, except when running in ci #4417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
splits the
dashboard/build.rs
into 2 separate mains. one for ci, and one for normal.Prior to the build.rs changes in #4272, you could manually install daft via
but after these changes, this no longer works.
So this PR essentially reverts those for everywhere except CI.
Notes regarding ci.
Maturin passes the
GITHUB_
env vars through to the image, so by detecting theGITHUB_ACTIONS
flag, the build should use the existing code path.so it should run as expected inside the CI.
Related Issues
Checklist
docs/mkdocs.yml
navigation