Skip to content

build: make dashboard self contained again, except when running in ci #4417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025

Conversation

universalmind303
Copy link
Contributor

Changes Made

splits the dashboard/build.rs into 2 separate mains. one for ci, and one for normal.

Prior to the build.rs changes in #4272, you could manually install daft via

uv pip install daft@file:///path/to/repo/Daft

but after these changes, this no longer works.

So this PR essentially reverts those for everywhere except CI.

Notes regarding ci.

Maturin passes the GITHUB_ env vars through to the image, so by detecting the GITHUB_ACTIONS flag, the build should use the existing code path.

so it should run as expected inside the CI.

⚠️ before merging, we must validate a manual run of the build CI.

Related Issues

Checklist

  • Documented in API Docs (if applicable)
  • Documented in User Guide (if applicable)
  • If adding a new documentation page, doc is added to docs/mkdocs.yml navigation
  • Documentation builds and is formatted properly (tag @/ccmao1130 for docs review)

@universalmind303 universalmind303 changed the title chore: make dashboard self contained again, except when running in ci ci: make dashboard self contained again, except when running in ci May 23, 2025
@github-actions github-actions bot added the chore label May 23, 2025
@universalmind303 universalmind303 changed the title ci: make dashboard self contained again, except when running in ci ci, build: make dashboard self contained again, except when running in ci May 23, 2025
@github-actions github-actions bot added ci and removed chore labels May 23, 2025
@universalmind303 universalmind303 changed the title ci, build: make dashboard self contained again, except when running in ci build: make dashboard self contained again, except when running in ci May 23, 2025
@github-actions github-actions bot added build and removed ci labels May 23, 2025
Copy link
Contributor

@srilman srilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely preferable over the make frontend approach, thanks!

Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.76%. Comparing base (3bffbfe) to head (01b5165).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4417      +/-   ##
==========================================
- Coverage   77.77%   77.76%   -0.01%     
==========================================
  Files         842      842              
  Lines      111937   111937              
==========================================
- Hits        87056    87052       -4     
- Misses      24881    24885       +4     

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@universalmind303
Copy link
Contributor Author

full CI passed. https://github.com/Eventual-Inc/Daft/actions/runs/15217176554

@kevinzwang, other than the release CI passing, is there anything else we need to do to verify this works as expected?

@kevinzwang
Copy link
Member

full CI passed. https://github.com/Eventual-Inc/Daft/actions/runs/15217176554

@kevinzwang, other than the release CI passing, is there anything else we need to do to verify this works as expected?

I was going to suggest try installing it from S3 but the S3 publish only builds for linux. Should be fine to just merge and try it out on the next release

@universalmind303 universalmind303 merged commit d2b94a6 into main May 23, 2025
53 of 55 checks passed
@universalmind303 universalmind303 deleted the cory/dashboard-ci-refactor branch May 23, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants