Skip to content

feat(flotilla): Add monotonically_increasing_id. #4717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 10, 2025

Conversation

rohitkulshreshtha
Copy link
Contributor

Changes Made

Added monotonically_increasing_id for flotilla.

@rohitkulshreshtha rohitkulshreshtha force-pushed the rohit/monotonically_increasing_id branch from d04db2e to cfab827 Compare July 10, 2025 18:17
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

Attention: Patch coverage is 79.10448% with 28 lines in your changes missing coverage. Please review.

Project coverage is 78.63%. Comparing base (4661c99) to head (2977f68).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...d/src/pipeline_node/monotonically_increasing_id.rs 67.85% 27 Missing ⚠️
src/daft-local-plan/src/plan.rs 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4717      +/-   ##
==========================================
+ Coverage   78.62%   78.63%   +0.01%     
==========================================
  Files         875      876       +1     
  Lines      122214   122332     +118     
==========================================
+ Hits        96085    96200     +115     
- Misses      26129    26132       +3     
Files with missing lines Coverage Δ
src/daft-distributed/src/pipeline_node/mod.rs 87.13% <ø> (ø)
...rc/daft-distributed/src/pipeline_node/translate.rs 94.17% <100.00%> (+0.53%) ⬆️
src/daft-distributed/src/stage/stage_builder.rs 53.55% <ø> (ø)
src/daft-local-execution/src/pipeline.rs 81.98% <100.00%> (+0.09%) ⬆️
.../src/streaming_sink/monotonically_increasing_id.rs 96.51% <100.00%> (+0.30%) ⬆️
src/daft-local-plan/src/translate.rs 88.41% <100.00%> (+0.03%) ⬆️
src/daft-logical-plan/src/builder/mod.rs 82.54% <100.00%> (+0.13%) ⬆️
src/daft-logical-plan/src/display.rs 100.00% <100.00%> (ø)
src/daft-logical-plan/src/display/json.rs 79.29% <100.00%> (ø)
src/daft-logical-plan/src/logical_plan.rs 72.22% <100.00%> (+0.16%) ⬆️
... and 5 more

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@srilman srilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @rohitkulshreshtha

@rohitkulshreshtha rohitkulshreshtha force-pushed the rohit/monotonically_increasing_id branch from cfab827 to edd5bc6 Compare July 10, 2025 19:36
@rohitkulshreshtha rohitkulshreshtha force-pushed the rohit/monotonically_increasing_id branch from edd5bc6 to 2977f68 Compare July 10, 2025 19:37
@rohitkulshreshtha rohitkulshreshtha enabled auto-merge (squash) July 10, 2025 19:38
@rohitkulshreshtha rohitkulshreshtha merged commit 3d4d02d into main Jul 10, 2025
48 checks passed
@rohitkulshreshtha rohitkulshreshtha deleted the rohit/monotonically_increasing_id branch July 10, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants