-
Notifications
You must be signed in to change notification settings - Fork 236
feat(flotilla): Add monotonically_increasing_id. #4717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-ho
reviewed
Jul 8, 2025
src/daft-distributed/src/pipeline_node/monotonically_increasing_id.rs
Outdated
Show resolved
Hide resolved
d04db2e
to
cfab827
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4717 +/- ##
==========================================
+ Coverage 78.62% 78.63% +0.01%
==========================================
Files 875 876 +1
Lines 122214 122332 +118
==========================================
+ Hits 96085 96200 +115
- Misses 26129 26132 +3
🚀 New features to boost your workflow:
|
srilman
approved these changes
Jul 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @rohitkulshreshtha
src/daft-distributed/src/pipeline_node/monotonically_increasing_id.rs
Outdated
Show resolved
Hide resolved
cfab827
to
edd5bc6
Compare
edd5bc6
to
2977f68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
Added
monotonically_increasing_id
for flotilla.