Skip to content

chore: add doc format and install dependency #4741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025

Conversation

Jay-ju
Copy link
Contributor

@Jay-ju Jay-ju commented Jul 10, 2025

Changes Made

Goal 1: When making docs, directly include relevant dependencies to prevent errors during runtime.
Goal 2: Added formatting for mkdocs.yml.

Related Issues

Checklist

  • Documented in API Docs (if applicable)
  • Documented in User Guide (if applicable)
  • If adding a new documentation page, doc is added to docs/mkdocs.yml navigation
  • Documentation builds and is formatted properly (tag @/ccmao1130 for docs review)

@github-actions github-actions bot added the fix label Jul 10, 2025
@Jay-ju
Copy link
Contributor Author

Jay-ju commented Jul 10, 2025

@colin-ho @ccmao1130 If you have time, please take a look at this PR. It's mainly about documentation - related content. Thanks.

Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.27%. Comparing base (31370fb) to head (0030d01).
Report is 22 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4741      +/-   ##
==========================================
+ Coverage   78.12%   78.27%   +0.14%     
==========================================
  Files         873      877       +4     
  Lines      121840   123659    +1819     
==========================================
+ Hits        95184    96788    +1604     
- Misses      26656    26871     +215     

see 75 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kevinzwang
Copy link
Member

@ccmao1130 could you take a look at this?

Copy link
Contributor

@ccmao1130 ccmao1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Jay-ju, thanks for opening this PR! The mkdocs.yml and additional make step and dependencies make sense. The only thing I want to push back on is deleting Docsearch because we wanted to integrate Algolia Docsearch instead of the native Mkdocs search for our documentation.

I can look into how we can improve our search crawler to reflect local searches

Comment on lines +11 to +12
yamllint
yamlfix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinzwang do these make sense to add?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have any yaml files in our docs afaik so let's not add these

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mkdocs.yml is yaml file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is true. If you'd like to lint that file though, could we add a linting step to the .pre-commit-config.yaml instead? It looks like yamllint is a supported hook

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the .pre-commit-config.yaml file has some default configurations, and it can also be checked in precommit currently. I'm not sure if I need to define a separate YAML format file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok, we can worry about it some other time. In the mean time let's just not add these dependencies since they aren't explicitly used anywhere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- id: check-yaml There seems to be a check here, but it doesn't seem to be taking effect. However, I guess it's because the mkdocs.yml is relatively newly created and this check hasn't been implemented.

@Jay-ju Jay-ju changed the title fix: doc search use local content chore: add doc format and install dependency Jul 11, 2025
@github-actions github-actions bot added chore and removed fix labels Jul 11, 2025
@Jay-ju
Copy link
Contributor Author

Jay-ju commented Jul 12, 2025

@ccmao1130 @kevinzwang Do you think an update is still needed? Please take a look when you have time.

@ccmao1130 ccmao1130 merged commit 568d3d8 into Eventual-Inc:main Jul 14, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants