Skip to content

fix(docs): Updated docs to correct calculate max rows per partition #4744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025

Conversation

rohitkulshreshtha
Copy link
Contributor

Changes Made

The monotonically increasing ID document has a small error in maximum rows per partition calculation. It should say 2^36 instead of 2^40.

@github-actions github-actions bot added the fix label Jul 10, 2025
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.06%. Comparing base (31370fb) to head (f4f0d43).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4744      +/-   ##
==========================================
- Coverage   78.12%   78.06%   -0.06%     
==========================================
  Files         873      873              
  Lines      121840   121842       +2     
==========================================
- Hits        95184    95122      -62     
- Misses      26656    26720      +64     
Files with missing lines Coverage Δ
daft/dataframe/dataframe.py 83.30% <ø> (ø)
daft/functions/functions.py 100.00% <ø> (ø)

... and 15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rohitkulshreshtha rohitkulshreshtha requested review from universalmind303 and srilman and removed request for universalmind303 July 10, 2025 19:11
Copy link
Contributor

@srilman srilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@rohitkulshreshtha rohitkulshreshtha merged commit 4fbf9c7 into main Jul 10, 2025
50 checks passed
@rohitkulshreshtha rohitkulshreshtha deleted the rohit/fix-monotonically-increasing-id-docs branch July 10, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants