Skip to content

feat(flotilla): Added concat #4748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 11, 2025
Merged

feat(flotilla): Added concat #4748

merged 5 commits into from
Jul 11, 2025

Conversation

rohitkulshreshtha
Copy link
Contributor

Added concat implementation for flotilla.

Copy link

codecov bot commented Jul 10, 2025

Codecov Report

Attention: Patch coverage is 73.62637% with 24 lines in your changes missing coverage. Please review.

Project coverage is 78.66%. Comparing base (01fca4a) to head (a4e128c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-distributed/src/pipeline_node/concat.rs 70.37% 24 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4748      +/-   ##
==========================================
- Coverage   78.68%   78.66%   -0.02%     
==========================================
  Files         877      878       +1     
  Lines      122583   122672      +89     
==========================================
+ Hits        96449    96496      +47     
- Misses      26134    26176      +42     
Files with missing lines Coverage Δ
src/daft-distributed/src/pipeline_node/mod.rs 86.74% <ø> (ø)
...rc/daft-distributed/src/pipeline_node/translate.rs 94.93% <100.00%> (+0.45%) ⬆️
src/daft-distributed/src/stage/stage_builder.rs 96.70% <100.00%> (ø)
src/daft-distributed/src/pipeline_node/concat.rs 70.37% <70.37%> (ø)

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rohitkulshreshtha rohitkulshreshtha marked this pull request as ready for review July 10, 2025 22:08
@rohitkulshreshtha rohitkulshreshtha enabled auto-merge (squash) July 11, 2025 00:07
@rohitkulshreshtha rohitkulshreshtha merged commit 3120919 into main Jul 11, 2025
48 checks passed
@rohitkulshreshtha rohitkulshreshtha deleted the rohit/concat branch July 11, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants