-
Notifications
You must be signed in to change notification settings - Fork 3.6k
improv: Ajustado isEmoji para aceitar todos os emojis. #1729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ricaelchiquetti
wants to merge
2
commits into
EvolutionAPI:develop
Choose a base branch
from
ricaelchiquetti:main
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+23
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideReplaces the handcrafted Unicode regex with the emoji-regex library in isEmoji and enforces that only strings composed of exactly one emoji return true. Class diagram for isEmoji function update in sendMessage.controller.tsclassDiagram
class SendMessageController {
}
class isEmoji {
+boolean isEmoji(str: string)
}
SendMessageController ..> isEmoji : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ricaelchiquetti - I've reviewed your changes - here's some feedback:
- Consider moving the call to emojiRegex() outside of isEmoji so the regex is only compiled once instead of on every function call.
- Double-check if you really want isEmoji('') to return true—treating an empty string as a valid emoji might be unintuitive.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider moving the call to emojiRegex() outside of isEmoji so the regex is only compiled once instead of on every function call.
- Double-check if you really want isEmoji('') to return true—treating an empty string as a valid emoji might be unintuitive.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descrição
Este PR melhora a função
isEmoji
nosendMessage.controller.ts
para validar corretamente strings que contêm apenas um emoji. A implementação anterior não deixava ser enviado alguns Emojis.O que foi feito
emoji-regex
.true
apenas se a string for exatamente um emoji.Summary by Sourcery
Improve emoji validation in sendMessage.controller by using emoji-regex to ensure only single-emoji strings return true
Enhancements:
Build: