Replace mfiter loops with the MF parallel for versions #1069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchdf
force-pushed
the
fused-mfiter
branch
4 times, most recently
from
be07d0a to
88f6ea4
Compare
mbkuhn
reviewed
Jul 8, 2024
marchdf
force-pushed
the
fused-mfiter
branch
2 times, most recently
from
05a9d3f to
b898303
Compare
marchdf
force-pushed
the
fused-mfiter
branch
2 times, most recently
from
e8ae2eb to
c246dc0
Compare
marchdf
force-pushed
the
fused-mfiter
branch
4 times, most recently
from
6ea9655 to
0960107
Compare
marchdf
force-pushed
the
fused-mfiter
branch
2 times, most recently
from
a8ae791 to
2100009
Compare
marchdf
force-pushed
the
fused-mfiter
branch
2 times, most recently
from
935f54b to
e586f3e
Compare
marchdf
force-pushed
the
fused-mfiter
branch
3 times, most recently
from
858f08f to
8c85df2
Compare
marchdf
force-pushed
the
fused-mfiter
branch
from
8c85df2 to
2c3857f
Compare
marchdf
force-pushed
the
fused-mfiter
branch
from
902aaea to
ba927e2
Compare
marchdf
force-pushed
the
fused-mfiter
branch
2 times, most recently
from
cd8d7d8 to
0abf331
Compare
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
marchdf
force-pushed
the
fused-mfiter
branch
2 times, most recently
from
ca660b0 to
c901cf6
Compare
marchdf
force-pushed
the
fused-mfiter
branch
3 times, most recently
from
ac6add8 to
c235946
Compare
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace mfiter loops with the MF parallel for versions. These take care of a bunch of defaults for use, creates fused parallelfors for the GPU (nominally results in faster code), and generally simplifies the code.
I am looking for volunteers. I have annotated all the mfiter loops that can be simplified. I probably missed some and some might not be doable on a second glance. I did a couple to show how it is done and there are other examples in the code.
Annotations are
// this onefor mfiter loop canditates.Also identified
// needs openmp pragma?for loops not containing openmp and that maybe should.I am using clang-format 18 to format the code, which causes the formatting check to break. But I am going to leave that alone so we don't waste resources and will fix the formatting later.
Pull request type
Please check the type of change introduced:
Checklist
This PR was tested by running: