Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat- Back button from expense detail leads to LHN rather than expense report conversation #54496

Open
4 of 8 tasks
mitarachim opened this issue Dec 24, 2024 · 16 comments
Open
4 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering

Comments

@mitarachim
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.78-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung s10/ chrome
App Component: Chat Report View

Action Performed:

  1. Navigate to https://staging.new.expensify.com
  2. Open any chat
  3. Submit an expense
  4. Navigate to expense detail page and click the top left back button

Expected Result:

The Back button navigate to expense conversation page

Actual Result:

Back button leads to LHN rather than expense report conversation

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6701565_1735002323431.Screen_Recording_20241224_035846_Chrome.mp4

View all open jobs on GitHub

@mitarachim mitarachim added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Dec 24, 2024
Copy link

melvin-bot bot commented Dec 24, 2024

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Dec 24, 2024

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Dec 24, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 24, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@daledah
Copy link
Contributor

daledah commented Dec 24, 2024

Edited by proposal-police: This proposal was edited at 2024-12-24 07:30:25 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Back button leads to LHN rather than expense report conversation

What is the root cause of that problem?

Offending PR: #53969

We are setting to go back to ROUTES.HOME here and go back with shouldPopToTop as true

Navigation.goBack(ROUTES.HOME, false, true);

What changes do you think we should make in order to solve the problem?

We should update route to undefined

 Navigation.goBack(undefined, false, true);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@DylanDylann
Copy link
Contributor

DylanDylann commented Dec 24, 2024

It came from this change

Screenshot 2024-12-24 at 16 26 59

@pac-guerreiro updated it to fix another bug. But now @pac-guerreiro is OOO. I will revert this change only to fix this bug

@daledah
Copy link
Contributor

daledah commented Dec 24, 2024

@RachCHopkins @cristipaval It is currently a deploy blocker that needs immediate attention. The previous PR addressed the issue in debug mode without impacting the production environment, so the fix should be straightforward.
If Dylan were to create the PR, we would need additional time for the C+ request and review process. However, since both @DylanDylann and I are online, I can quickly create a PR within 5 minutes and have @DylanDylann review it right away.

@DylanDylann
Copy link
Contributor

@daledah Thanks for your concern, It seems to make sense. I haven't started on it.

@cristipaval What do you think about it? because @pac-guerreiro (the author of the offending PR) is OOO, @daledah can help to raise a PR because they also take time to investigate and find the RCA. Then we can compensate them a part

@cristipaval
Copy link
Contributor

@daledah, thanks for jumping in! Please go ahead with your solution

Copy link

melvin-bot bot commented Dec 24, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@Beamanator
Copy link
Contributor

That ^ was me linking #54508 to this one b/c they look like the same root cause

@daledah
Copy link
Contributor

daledah commented Dec 24, 2024

I'll raise PR soon

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Dec 24, 2024
@daledah
Copy link
Contributor

daledah commented Dec 24, 2024

@DylanDylann we have a open PR here

This comment was marked as off-topic.

@Beamanator
Copy link
Contributor

PR Merged & CP'd, waiting on test!

@Beamanator Beamanator removed Reviewing Has a PR in review DeployBlockerCash This issue or pull request should block deployment Weekly KSv2 DeployBlocker Indicates it should block deploying the API labels Dec 25, 2024
@Beamanator
Copy link
Contributor

Fixed in staging so removed blocker label!

I believe we need to pay out @daledah for the fix before closing this out, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering
Projects
None yet
Development

No branches or pull requests

6 participants