fix: ignore Onyx update from GetMissingOnyxMessages for submit report #54450
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
It ignores Onyx updates from
GetMissingOnyxMessagesresponse whensubmitReportAPI got its response. About the issue we couldn't keepsubmitReport's response from activatingGetMissingOnyxMessagescommand. SoGetMissingOnyxMessagescommand should be activated aftersubmitReport's response. From #53226, button's UI has the blinking issue because Onyx updates fromSubmittoPaytoSubmittoPay. The reasonSubmitpops while Onyx updating is thatGetMissingOnyxMessages's response(with status num forSubmit) updates Onyx just afterPayis updated. So this fix ignore Onyx update forSubmit.The issue:
2nd
Submitbutton occurs forGetMissingOnyxMessagescommand's response aftersubmitReport's response.What is fixed:
Ignores
GetMissingOnyxMessagescommand's response while activatingGetMissingOnyxMessagesrequest forsubmitReportcase.$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop