Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SQLiteScopedHandle in OpenDBHandlesAndRunQuery #2132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

flodnv
Copy link
Contributor

@flodnv flodnv commented Mar 17, 2025

Details

https://expensify.slack.com/archives/C05CBC62HGW/p1742242058021559?thread_ts=1741899101.373909&cid=C05CBC62HGW

Fixed Issues

For https://github.com/Expensify/Expensify/issues/458560

Tests

Ran

OpenDBHandlesAndRunQuery
handlesCount:100
maxThreads:5

->

2025-03-17T20:14:32.461400+00:00 expensidev2004 bedrock: xxxxxx (BedrockServer.cpp:2033) _control [socket0] [info] Initialized 100 DB handles, cleaning up.
2025-03-17T20:14:32.461466+00:00 expensidev2004 bedrock: xxxxxx (SQLitePool.cpp:85) returnToPool [socket0] [dbug] DB handle returned to pool.
2025-03-17T20:14:32.465271+00:00 expensidev2004 bedrock: message repeated 99 times: [ xxxxxx (SQLitePool.cpp:85) returnToPool [socket0] [dbug] DB handle returned to pool.]
2025-03-17T20:14:32.465309+00:00 expensidev2004 bedrock: xxxxxx (BedrockServer.cpp:2037) _control [socket0] [info] Returned 100 DB handles.
2025-03-17T20:14:32.465390+00:00 expensidev2004 bedrock: xxxxxx (BedrockCommand.cpp:286) finalizeTimingInfo [socket0] [info] command 'OpenDBHandlesAndRunQuery' timing info (ms): prePeek:0 (count: 0), peek:0 (count:0), process:0 (count:0), postProcess:0 (count:0), total:109, unaccounted:109, blockingCommitThreadTime:0, exclusiveTransactionLockTime:0. Commit: worker:0, sync:0. Queue: worker:0, sync:0, blocking:0, pageLock:0, escalation:0. Blocking: prePeek:0, peek:0, process:0, postProcess:0, commit:0. Upstream: peek:0, process:0, total:0, unaccounted:0.

Internal Testing Reminder: when changing bedrock, please compile auth against your new changes

@flodnv flodnv requested a review from tylerkaraszewski March 17, 2025 20:16
@flodnv flodnv self-assigned this Mar 17, 2025
Copy link
Contributor

@tylerkaraszewski tylerkaraszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will work as it does basically the same thing that the existing code already does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants