Setup ci tests #119
Merged
Setup ci tests #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carlosmiceli Pullerbear doesn't work in this repo and GitHub suggested you for review and I just went with it |
|
No prob sir! Main question is what's the reasoning and logic for the rule exceptions you're introducing ( |
|
Mostly just expedience and not wanting to break stuff 🙂 |
carlosmiceli
approved these changes
Oct 3, 2024
|
🚀 Published in 2.0.61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from https://expensify.slack.com/archives/C049HHMV9SM/p1727942903497109
We have lint and test in this repo but don't run them on PRs, so their value is diminished. Also, they can be broken without us noticing, which makes work for other people in the future to fix them.
This PR adds jest and eslint workflows to PRs, and gets them both passing.