Automatically publish eslint config on merge #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roryabraham
commented
Oct 1, 2023
| - name: Publish to npm | ||
| run: npm publish | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} |
There was a problem hiding this comment.
Hoping that since secrets are defined at the org level that this will be available in this repo automatically. If not we can just follow-up with a ring0 issue to add secrets (and maybe to give OSBotify the same access he has in E/App).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Expensify/Expensify/issues/212068
This workflow is exactly the same as what we have for react-native-onyx and react-native-key-command.
It's worth noting that all three could be simplified by allowing OSBotify to push straight to main, as he does in E/App for version-bump commits. However, this has been working fine so not a necessarily a problem for these less-frequently-updated repos.