Add Not Overdue filter #261
Conversation
| preparedIssues = _.filter(preparedIssues, (item) => { | ||
| const isHeld = item.title.toLowerCase().indexOf('[hold') > -1 ? ' hold' : ''; | ||
| const isUnderReview = _.find(item.labels, label => label.name.toLowerCase() === 'reviewing'); | ||
| const isOwnedBySomeoneElse = item.issueHasOwner && !item.currentUserIsOwner; | ||
| const isOverdue = _.findWhere(item.labels, {name: 'Overdue'}); |
There was a problem hiding this comment.
I'm not sure if it matters, but this is slightly different than how we look for the reviewing label (which is case insensitive).
_.find(item.labels, label => label.name.toLowerCase() === 'reviewing');
There was a problem hiding this comment.
ah yeah, i can update that to be safe! I think there's somewhere else that does it that way too, I'll fix both.
|
Going to defer review to @tgolen as he has lots of good comments! I quickly skimmed and it's looking good |
|
updated! it looks like we use both ways throughout the app for different labels ( |
|
I think it's probably OK. Thanks for looking! |
|
You'll need to ask a ring3 person to deploy this |
Ever wanted to see only your overdue issues? Now you can!
Brought to you primarily by Cursor and vibe coding, which is neat.
$ https://github.com/Expensify/Expensify/issues/507736