Skip to content

Add iOS Apple Wallet module #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 47 commits into from
Apr 2, 2025
Merged

Add iOS Apple Wallet module #12

merged 47 commits into from
Apr 2, 2025

Conversation

Skalakid
Copy link
Collaborator

@Skalakid Skalakid commented Feb 28, 2025

Details

This PR adds the iOS Apple Wallet module for the react-native-wallet library. It adds following features:

  • checking Wallet availability
  • getting card status using the card's last 4 digits
  • adding a card to the Apple Wallet
  • custom card activation event listener
  • basic Add To Apple Wallet buttons (en and es)
ScreenRecording_03-20-2025.16-17-54_1.MP4

Related Issues

GH_LINK

Manual Tests

Linked PRs

@Skalakid Skalakid changed the title @skalakid/ios module Add iOS Apple Wallet module Feb 28, 2025
@Skalakid Skalakid force-pushed the @Skalakid/ios-module branch from 4a39fd9 to 7e1ff4e Compare March 13, 2025 10:24
@Skalakid Skalakid requested review from zfurtak and WoLewicki March 20, 2025 15:29
Copy link
Collaborator

@zfurtak zfurtak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!! 🚀 I left a few comments to discuss a little 🤓

@zfurtak
Copy link
Collaborator

zfurtak commented Mar 20, 2025

One more thought, did you check if android is working after the changes? 🤖

@Skalakid Skalakid marked this pull request as ready for review March 24, 2025 09:26
Copy link
Collaborator

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments!


presentAddPaymentPassCompletionHandler = completion
DispatchQueue.main.async {
RCTPresentedViewController()?.present(enrollViewController, animated: true, completion: nil)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully it works with all kinds of modals, did you maybe test it in e.g. some native-stack with modal opened ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, but good idea. I will test it

@Skalakid Skalakid force-pushed the @Skalakid/ios-module branch from fba2599 to 9e6d4a9 Compare March 25, 2025 11:34
@Skalakid Skalakid requested a review from WoLewicki April 1, 2025 12:13
Copy link
Collaborator

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments, looks good!

@Skalakid Skalakid requested review from WoLewicki and zfurtak April 2, 2025 11:32
@Skalakid Skalakid force-pushed the @Skalakid/ios-module branch from 0b08262 to 2eacd6a Compare April 2, 2025 12:52
Copy link
Collaborator

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@zfurtak zfurtak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! ✨🥳💪

@Skalakid Skalakid merged commit 6757b93 into main Apr 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants