-
Notifications
You must be signed in to change notification settings - Fork 1
Add iOS Apple Wallet module #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4a39fd9
to
7e1ff4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!! 🚀 I left a few comments to discuss a little 🤓
example/ios/WalletExample.xcodeproj/xcshareddata/xcschemes/WalletExample.xcscheme
Show resolved
Hide resolved
One more thought, did you check if android is working after the changes? 🤖 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments!
ios/WalletManager.swift
Outdated
|
||
presentAddPaymentPassCompletionHandler = completion | ||
DispatchQueue.main.async { | ||
RCTPresentedViewController()?.present(enrollViewController, animated: true, completion: nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully it works with all kinds of modals, did you maybe test it in e.g. some native-stack
with modal opened ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet, but good idea. I will test it
fba2599
to
9e6d4a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments, looks good!
0b08262
to
2eacd6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work! ✨🥳💪
Details
This PR adds the iOS Apple Wallet module for the
react-native-wallet
library. It adds following features:Add To Apple Wallet
buttons (en and es)ScreenRecording_03-20-2025.16-17-54_1.MP4
Related Issues
GH_LINK
Manual Tests
Linked PRs