Skip to content

Try catch turbo module linking #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 16, 2025

Conversation

Skalakid
Copy link
Collaborator

@Skalakid Skalakid commented Apr 1, 2025

Details

This PR ad try-catch around the turbo module linking, so platforms that aren't supported won't crash the app

Related Issues

GH_LINK

Manual Tests

Linked PRs

@Skalakid Skalakid changed the base branch from main to @Skalakid/ios-module April 1, 2025 13:36
@Skalakid Skalakid changed the base branch from @Skalakid/ios-module to main April 3, 2025 08:48
@Skalakid Skalakid force-pushed the @Skalakid/try-catch-turbo-module-linking branch from cabfa87 to 4c3a865 Compare April 3, 2025 08:56
@zfurtak zfurtak force-pushed the @Skalakid/try-catch-turbo-module-linking branch from 976bec4 to 90adebb Compare April 9, 2025 08:24
@Skalakid Skalakid marked this pull request as ready for review April 9, 2025 10:53
@Skalakid Skalakid requested a review from zfurtak April 15, 2025 14:08
Copy link
Collaborator

@zfurtak zfurtak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Skalakid Skalakid merged commit 025acb4 into main Apr 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants