fix: creatives without transcoded assets are not included in the VAST…

… response Signed-off-by: Fredrik Lundkvist <[email protected]>
Eyevinn · Jan 24, 2025 · 7a5243d · 7a5243d
1 parent 0aeab75
commit 7a5243d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/encore/encoreclient.test.ts b/src/encore/encoreclient.test.ts
@@ -1,6 +1,5 @@
 import { EncoreClient } from './encoreclient';
 import { EncoreJob, InputType } from './types';
-import { ManifestAsset } from '../vast/vastApi';
 
 jest.mock('../util/logger', () => ({
   info: jest.fn()

diff --git a/src/vast/vastApi.ts b/src/vast/vastApi.ts
@@ -279,7 +279,7 @@ const replaceMediaFiles = (vastXml: string, assets: ManifestAsset[]) => {
     const parser = new XMLParser({ ignoreAttributes: false });
     const parsedVAST = parser.parse(vastXml);
     if (parsedVAST.VAST.Ad) {
-      for (const ad of parsedVAST.VAST.Ad) {
+      parsedVAST.VAST.Ad = parsedVAST.VAST.Ad.reduce((acc: any[], ad: any) => {
         const adId = ad.InLine.Creatives.Creative.UniversalAdId[
           '#text'
         ].replace(/[^a-zA-Z0-9]/g, '');
@@ -289,8 +289,10 @@ const replaceMediaFiles = (vastXml: string, assets: ManifestAsset[]) => {
             asset.masterPlaylistUrl;
           ad.InLine.Creatives.Creative.Linear.MediaFiles.MediaFile['@_type'] =
             'application/x-mpegURL';
+          acc.push(ad);
         }
-      }
+        return acc;
+      }, []);
     }
     const builder = new XMLBuilder({ format: true, ignoreAttributes: false });
     const modifiedVastXml = builder.build(parsedVAST);