fix: handle situations where there is only one ad in VAST

Eyevinn · Feb 5, 2025 · 7e42766 · 7e42766
1 parent 4826cb1
commit 7e42766
Showing 1 changed file with 58 additions and 22 deletions.
diff --git a/src/vast/vastApi.ts b/src/vast/vastApi.ts
@@ -254,18 +254,29 @@ const getVastXml = async (
 const getCreatives = async (vastXml: any): Promise<ManifestAsset[]> => {
   try {
     if (vastXml.VAST.Ad) {
-      const creatives = vastXml.VAST.Ad.reduce(
-        (acc: ManifestAsset[], ad: any) => {
-          const adId = ad.InLine.Creatives.Creative.UniversalAdId[
+      if (!Array.isArray(vastXml.VAST.Ad)) {
+        const adId = vastXml.VAST.Ad.InLine.Creatives.Creative.UniversalAdId[
+          '#text'
+        ].replace(/[^a-zA-Z0-9]/g, '');
+        const mediaFile =
+          vastXml.VAST.Ad.InLine.Creatives.Creative.Linear.MediaFiles.MediaFile[
             '#text'
-          ].replace(/[^a-zA-Z0-9]/g, '');
-          const mediaFile =
-            ad.InLine.Creatives.Creative.Linear.MediaFiles.MediaFile['#text'];
-          return [...acc, { creativeId: adId, masterPlaylistUrl: mediaFile }];
-        },
-        []
-      );
-      return creatives;
+          ];
+        return [{ creativeId: adId, masterPlaylistUrl: mediaFile }];
+      } else {
+        const creatives = vastXml.VAST.Ad.reduce(
+          (acc: ManifestAsset[], ad: any) => {
+            const adId = ad.InLine.Creatives.Creative.UniversalAdId[
+              '#text'
+            ].replace(/[^a-zA-Z0-9]/g, '');
+            const mediaFile =
+              ad.InLine.Creatives.Creative.Linear.MediaFiles.MediaFile['#text'];
+            return [...acc, { creativeId: adId, masterPlaylistUrl: mediaFile }];
+          },
+          []
+        );
+        return creatives;
+      }
     }
     return [];
   } catch (error) {
@@ -279,20 +290,41 @@ const replaceMediaFiles = (vastXml: string, assets: ManifestAsset[]) => {
     const parser = new XMLParser({ ignoreAttributes: false });
     const parsedVAST = parser.parse(vastXml);
     if (parsedVAST.VAST.Ad) {
-      parsedVAST.VAST.Ad = parsedVAST.VAST.Ad.reduce((acc: any[], ad: any) => {
-        const adId = ad.InLine.Creatives.Creative.UniversalAdId[
-          '#text'
-        ].replace(/[^a-zA-Z0-9]/g, '');
+      if (!Array.isArray(parsedVAST.VAST.Ad)) {
+        const adId = reFormatAdId(
+          parsedVAST.VAST.Ad.InLine.Creatives.Creative.UniversalAdId['#text']
+        );
         const asset = assets.find((asset) => asset.creativeId === adId);
         if (asset) {
-          ad.InLine.Creatives.Creative.Linear.MediaFiles.MediaFile['#text'] =
-            asset.masterPlaylistUrl;
-          ad.InLine.Creatives.Creative.Linear.MediaFiles.MediaFile['@_type'] =
-            'application/x-mpegURL';
-          acc.push(ad);
+          logger.debug('Replacing media file', { asset });
+          parsedVAST.VAST.Ad.InLine.Creatives.Creative.Linear.MediaFiles.MediaFile[
+            '#text'
+          ] = asset.masterPlaylistUrl;
+          parsedVAST.VAST.Ad.InLine.Creatives.Creative.Linear.MediaFiles.MediaFile[
+            '@_type'
+          ] = 'application/x-mpegURL';
         }
-        return acc;
-      }, []);
+      } else {
+        parsedVAST.VAST.Ad = parsedVAST.VAST.Ad.reduce(
+          (acc: any[], ad: any) => {
+            const adId = reFormatAdId(
+              ad.InLine.Creatives.Creative.UniversalAdId['#text']
+            );
+            const asset = assets.find((asset) => asset.creativeId === adId);
+            if (asset) {
+              ad.InLine.Creatives.Creative.Linear.MediaFiles.MediaFile[
+                '#text'
+              ] = asset.masterPlaylistUrl;
+              ad.InLine.Creatives.Creative.Linear.MediaFiles.MediaFile[
+                '@_type'
+              ] = 'application/x-mpegURL';
+              acc.push(ad);
+            }
+            return acc;
+          },
+          []
+        );
+      }
     }
     const builder = new XMLBuilder({ format: true, ignoreAttributes: false });
     const modifiedVastXml = builder.build(parsedVAST);
@@ -303,6 +335,10 @@ const replaceMediaFiles = (vastXml: string, assets: ManifestAsset[]) => {
   }
 };
 
+const reFormatAdId = (adId: string) => {
+  return adId.replace(/[^a-zA-Z0-9]/g, '');
+};
+
 const parseVast = (vastXml: string) => {
   try {
     const parser = new XMLParser({ ignoreAttributes: false });