CalcMinVersion methods for both Master and Media playlists #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements all Compatibility Version rules except the ones for SKIP. The sample playlists have been updated to follow the new rules.
tobbee
force-pushed
the
feat-calc-min-ver
branch
from
443aadd to
4ebec73
Compare
tobbee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choosing the right, or at least a high enough playlist version for HLS is not easy. The new methods calculate the minimal version depending on the HLS elements of master based on the HLS Protocol Version Compatibility rules should be helpful.
A number or the sample playlists where not compliant, so they were updated.