-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ludt box support #262
Conversation
@tanghaowillow Thanks for the PR. I'm a bit tight on time right now, but I will try to go through it in the next few days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
The main issue I see is that non-zero loudness_info_type
values are not detected and would lead to broken parsing. Returning an error for non-zero values may be a good enough for now, but just parsing the extra byte and storing the two values would be a cleaner solution.
The test file you found is good to have, but is not used in any test as far as I can see. Maybe just extracting the ludt
box data and decode it could be a good test.
Please check my other comments as well.
In any case, really nice to receive such a good PR.
@tobbee Thanks for your advice. I have modified the code according to the comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me with the changes including the box test and the error for a non-supported value.
Thanks a lot for your contribution!
@tanghaowillow |
@tanghaowillow Your PR has now been merged. Good work! Welcome back if you want to contribute with other code or file an issue! |
Add
ludt
,alou
andtlou
support.Fixes #240
The only test file I could find was from MPEGGroup/isobmff#38.