Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get session vmap xml through new endpoint #84

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

Kajlid
Copy link
Contributor

@Kajlid Kajlid commented Jun 11, 2024

GET/sessions/:sessionId/vmap was created in routes.js to solve issue #76 as a part of current sprint iteration of Student Video Dev Team.

@Kajlid Kajlid added the enhancement New feature or request label Jun 11, 2024
@oshinongit
Copy link

LGTM

We can let @Nfrederiksen be the determinant reviewer here since he has full knowledge of the functionality. So when he approves I say it is free to merge:)

Copy link
Collaborator

@Nfrederiksen Nfrederiksen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Excellent this looks good.

Copy link

@oshinongit oshinongit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nfrederiksen Nfrederiksen merged commit 53957b5 into main Jun 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants