77 feature request support for returning pause ads#86
Merged
Nfrederiksen merged 6 commits intomainfrom Feb 20, 2025
Merged
Conversation
- Add new /pause-ad endpoint schema in routes.js - Implement GET handler for /pause-ad in routes.js
- Create new file utils/pause-ad-vast-maker.js - Implement PauseAdVastBuilder function
- Update Session class to handle pause ad requests - Add getPauseAdVast method to Session class
- Add PAUSE_AD to RESPONSE_FORMATS in constants.js
Updated .addStaticResource in pause-ad-vast-maker.js so that the attributes of the NonLinear ad is recognised properly (such as maintainAspectRatio), also removed some console logging.
Nfrederiksen
approved these changes
Feb 20, 2025
Collaborator
Nfrederiksen
left a comment
There was a problem hiding this comment.
I admit being late to review, but this PR looks good to me. It all works pretty much as desired. There is a second part to this though but I'll make a separate ticket for it.
Lovely done all involved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Support for Pause Ads
This PR implements a new feature to support Pause Ads in the test-adserver. It adds a new endpoint
/pause-adthat returns a VAST XML response suitable for pause ads.Changes
/pause-adendpoint that generates and returns a VAST XML for pause adsPauseAdVastBuilderto create VAST XML specifically for pause adsSessionclass to handle pause ad requestsPAUSE_ADto constantsTesting
The VAST XML generated has been tested with the Video Suite Inspector (https://googleads.github.io/googleads-ima-html5/vsi/).
Observations:
but only a cropped part of it is shown.Questions:
What might be causing only a cropped part of the image to be visible, and how can we address this?(Fixed)Notes