Adds the ability to bind the side mouse buttons #96
+68
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, that is exciting! @4z0t are you available to review this? |
|
From first glance it looks ok. But I have some style wise remarks in mind. Such as putting constexpr where it doesn't make sense and making class defined in function. |
|
Ok, this one makes sense |
4z0t
requested changes
Nov 10, 2024
4z0t
approved these changes
Nov 10, 2024
Garanas
force-pushed
the
supportxbuttons
branch
from
48295e4
to
71dbc8d
Compare
4z0t
pushed a commit
to 4z0t/FA-Binary-Patches
that referenced
this pull request
Nov 11, 2024
Supports the buttons that are identified with `XButton1` and `XButton2`
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to bind the side mouse buttons (XButton1 and XButton2).
Requires changes in the lua repository
