Add playercard, fix mapgen options, replay scoreboard is now proper widget, not html string #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Gatsik
commented
Aug 2, 2024
Gatsik
commented
- Add player card, which mocks java client's one, but has some enhancements
- Make it possible to select player and show information about them from the replay scoreboard's context menu
- Fix incompatibility with new map generator, allow generating by mapname
- Other various fixes
which in many ways mocks java client's one
(i mean, there are probably lots of them, but this one triggered me for some reason)
because java client does it, thus we don't redownload already downloaded avatars with spaces in names
this automatically 'caches' fetched rating history for different leaderboards because each tab has its own data and plot and it's also more convenient than combo box
... and prettify their display names
map generator exits with 0 on wrong command line options so the only way to check if error happened is to read from stderr but the library, which map generator uses, also prints the output of --help command after the error message Starting from this commit we don't act upon second message only log it just in case something else happened
to eliminite some duplicate code also, add missed --num-teams argument
we are unable to predefine number of steps it will take to generate a map and seeing progress stuck at on of the first steps when all the work is done in it is somewhat annoying (using --debug option to display more information about progress significantly (2x) slows down generation process, so we won't use that)
(or at least try to do so)
some avatars' urls return 404
this fixes circular dependency me -> relations -> me although it sound logical that User has relations there is only one user, whose relations are known and managable -- the client user (me) so it is also logical for User class to not have those relations and maybe UserRelations should be the class, from which we should get 'me', not the other way around
1. there are multiple leaderboards and their count can change 2. its behaviour is very inconvenient
it only needs avatar downloader
(special icon and no league name)
do not 'pre-parse' API response -- extract data directly from the dictionary json.load provided rating history responses can be very large -- tens of thousands of records, and skipping default API response parsing and convertion parsed data into pydantic models (especially skipping pydantic) saves lots of time additionally, using numpy arrays over python lists and deleting unused data structures saves memory
don't create overhead signals and inherit LineSeriesParser directly from QThread
it requires additional libraries to be installed to work properly
so black numbers are visible on it
since a7197c7 view_replays uses only player's login to search
which allows to disable ingame notification for everything except the GAME_FULL notification * apply common enabling/disabling rules to party invite notification * fix NEW_GAME notification
the .msi file is stored in the 'dist' directory
the ImageDownloader's get_image method accepts url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.