Add replay card, improve vaults UI and some other things #1140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to show time and number of players in queue immediately and not wait for this information in the next message
…o add having only 1 queue is something that probably won't ever happen in production, but on test server it can be the thing
actually almost entirely integrate livereplaysever project into client see https://github.com/fafafaf/livereplayserver
in addition to map generation
because of recently added fields `game_type` and `hosted_at` to `Game` model
with the following options: - Join game - Preview map
and indicate replay unavailability in replay tree
game stats are received at the end of the game, so most (if not all) of the parsed data is valid
API failures have been happening a lot lately
to avoid partially extracted options
they are modal, therefore minimize button is sort of useless
(VaultItemWidget, PlayerInfoDialog, ReplayDetailsCard)
(if map is installed)
there are lots of different parsers in many languages, including python, C#, Java, JavaScript, Rust (this one even has a python bindings), but all of them are not suitable for our needs. With our own parser we can parse and skip whatever we want, whenever we want, and do not depend on third party implementations. (which also means that we do not have to do any post-processing of the data in slow python)
parsing is now significantly faster than downloading and, without mentioning the download time, it's hard to believe that the actual parsing took so little compared to the the whole noticeable download-parse process time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporate LiveReplayServer by fafafaf, but without server part, and rewrite its replay parser in zig to increase parsing speeds
Embrace exponentials