#319 adding 3 columns to matchmaker_queue_map_pool table#320
#319 adding 3 columns to matchmaker_queue_map_pool table#320Brutus5000 merged 2 commits intoFAForever:developfrom
Conversation
| ALTER TABLE matchmaker_queue_map_pool | ||
| ADD COLUMN veto_tokens_per_player TINYINT UNSIGNED DEFAULT 0 NOT NULL, | ||
| ADD COLUMN max_tokens_per_map TINYINT UNSIGNED DEFAULT 0 NOT NULL, | ||
| ADD COLUMN minimal_maps_allowed FLOAT DEFAULT 1 NOT NULL CHECK (minimal_maps_allowed >= 1); No newline at end of file |
There was a problem hiding this comment.
I would name minimal_maps_allowed differently. It is a restriction, not an allowance. I get what it is supposed to mean, but it is a bit confusing. Maybe minimal_maps_left?
There was a problem hiding this comment.
I don't understand either of the names. What is the effect of this value?
There was a problem hiding this comment.
I don't understand either of the names. What is the effect of this value?
its the minimal maps count which should left after all vetoes applied
There was a problem hiding this comment.
system will nerf veto tokens if necessary until this is true
There was a problem hiding this comment.
about the name i dont really care, but PRs to the api and mod client should also be changed accordingly, if you change it
There was a problem hiding this comment.
I like minimum_maps_after_veto. It's a descriptive name.
There was a problem hiding this comment.
ok i will set "minimum_maps_after_veto" and will update other repos / PRs accordingly
There was a problem hiding this comment.
i want to set it like CHECK (minimum_maps_after_veto > 0)
but this can lead to questions like "what is 0.5 maps after veto means"
should i rename it to "minimal_sum_of_map_weights_after_veto" instead?
There was a problem hiding this comment.
that would be more accurate description of the variable
There was a problem hiding this comment.
|
renamed the column |
3 participants
solves #319