Remove the current implementation to block paintings (#6949)

The chat configuration needs to be bugfixed so that people cannot block their own paintings and so that the mute config doesn't save across sessions.

Author: Garanas

loc/US/strings_db.lua

@@ -3737,7 +3737,7 @@ chat_0008="Chat Options"
 chat_0009="Chat Font Size"
 chat_0010="Window Fade Time"
 chat_0011="Window Alpha"
-chat_0012="Message/Painting Filters"
+chat_0012="Message Filters"
 chat_0013="Message Colors"
 chat_0014='Show Feed Background'
 chat_0015='Persist Feed Timeout'
@@ -5639,7 +5639,7 @@ tooltipui0398="Click here to send your message to all of your allies."
 tooltipui0399="All Chat"
 tooltipui0400="Click here to send your message to all players."
 tooltipui0401="Chat Filters"
-tooltipui0402="Show or hide messages and paintings from players"
+tooltipui0402="Show or hide messages from players"
 tooltipui0403="Chat Color"
 tooltipui0404="Change the font color for various messages"
 tooltipui0405="Font Size"

lua/ui/game/chat.lua

@@ -1441,7 +1441,7 @@ function CreateConfigWindow()
         end
     end
 
-    local filterTitle = UIUtil.CreateText(optionGroup, '<LOC chat_0012>Message/Painting Filters', 14, "Arial Bold")
+    local filterTitle = UIUtil.CreateText(optionGroup, '<LOC chat_0012>Message Filters', 14, "Arial Bold")
     LayoutHelpers.AtLeftTopIn(filterTitle, optionGroup, 5, 5)
     Tooltip.AddControlTooltip(filterTitle, 'chat_filter')
     local index = 1

lua/ui/game/painting/Painting.lua

@@ -28,15 +28,13 @@ local DefaultPaintingDuration = 25
 ---@class UIPainting : DebugComponent, Destroyable
 ---@field BrushStrokes TrashBag     # All brush strokes, including those shared by peers.
 ---@field WorldView WorldView
----@field BlockedAuthors table<string, boolean>
 Painting = Class(DebugComponent) {
 
     DefaultPaintingDuration = 25,
 
     ---@param self UIPainting
     __init = function(self)
         self.BrushStrokes = TrashBag()
-        self.BlockedAuthors = {}
     end,
 
     ---@param self UIPainting
@@ -53,11 +51,8 @@ Painting = Class(DebugComponent) {
     ---@param delta number
     OnRender = function(self, delta)
         -- render allowed brush strokes
-        local blockedAuthors = self.BlockedAuthors
         ---@param brushStroke UIBrushStroke
         for k, brushStroke in self.BrushStrokes do
-            if blockedAuthors[brushStroke.Author] then continue end
-
             local ok, msg = pcall(brushStroke.OnRender, brushStroke, delta)
             if not ok and self.EnabledErrors then
                 WARN(msg)

lua/ui/game/painting/PaintingCanvas.lua

@@ -32,10 +32,6 @@ local PaintingCanvasInstances = TrashBag()
 
 local SyncIdentifier = "PaintingCanvas.lua"
 
-local armyTable = GetArmiesTable()
-local numArmies = armyTable.numArmies
-local armiesTable = armyTable.armiesTable
-
 ---@alias UIPaintingCanvasActiveInteraction 'Create' | 'Delete' | 'Mute'
 
 --- Responsible for glueing together the painting, the brush stroke and the painting network adapter.
@@ -62,15 +58,6 @@ PaintingCanvas = Class(Bitmap, DebugComponent) {
         -- register us to render
         self.WorldView:AddShape(self, tostring(self))
 
-        -- register us to read chat options
-        import('/lua/ui/game/chat.lua').AddChatOptionSetCallback(function(chatOptions)
-            local blockedAuthorsTable = self.Painting.BlockedAuthors
-            for armyIndex = 1, numArmies do
-                -- the chat option marks the checkbox status, true = view chat, false = hide chat
-                blockedAuthorsTable[armiesTable[armyIndex].nickname] = chatOptions[armyIndex] == false
-            end
-        end)
-
         self.InhibitionSet = {}
     end,
 

lua/ui/help/tooltips.lua

@@ -375,7 +375,7 @@ Tooltips = {
     },
     chat_filter = {
         title = "<LOC tooltipui0401>Chat Filters",
-        description = "<LOC tooltipui0402>Show or hide messages and paintings from players",
+        description = "<LOC tooltipui0402>Show or hide messages from players",
     },
     chat_color = {
         title = "<LOC tooltipui0403>Chat Color",