-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a reference to NXmpes from NXarpes #153
Conversation
@rettigl @lukaspie @Tommaso-Pincelli What are your opinions on this? |
I like the reference in general. I don't have a good overview whether NXarpes has been used or is still in use. If it is not even used anymore, I don't think such a conversion is necessary. If we want to do it, we can however provide a json file that maps from the original NXarpes to NXmpes through pynxtools. If nobody uses it, we could also suggest NIAC to make NXarpes deprecated if we want to have an even stronger statement. |
Yeah I think whether it is used can only answer the NIAC but even then we might not know if it might be used somewhere unknowingly. So my suggestion is to keep it at least as legacy support as a definition. |
I also like the reference idea. For conversion (and deprication), we should check that we don't have any required items in NXmpes/NXphotoemission which are not available in NXarpes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@domna I slightly modified the reference so that it references NXmpes
AND NXmpes_arpes
. Feel free to merge.
Thanks! |
* Add a reference to NXmpes to NXarpes * Make reference an actual rst link * Refer to `NXmpes_arpes` * modify reference to NXmpes_arpes --------- Co-authored-by: Lukas Pielsticker <[email protected]>
* Add a reference to NXmpes to NXarpes * Make reference an actual rst link * Refer to `NXmpes_arpes` * modify reference to NXmpes_arpes --------- Co-authored-by: Lukas Pielsticker <[email protected]> # Conflicts: # applications/NXarpes.nxdl.xml # applications/nyaml/NXarpes.yaml
* Add a reference to NXmpes to NXarpes * Make reference an actual rst link * Refer to `NXmpes_arpes` * modify reference to NXmpes_arpes --------- Co-authored-by: Lukas Pielsticker <[email protected]> # Conflicts: # applications/NXarpes.nxdl.xml # applications/nyaml/NXarpes.yaml
* Add a reference to NXmpes to NXarpes * Make reference an actual rst link * Refer to `NXmpes_arpes` * modify reference to NXmpes_arpes --------- Co-authored-by: Lukas Pielsticker <[email protected]> # Conflicts: # applications/NXarpes.nxdl.xml # applications/nyaml/NXarpes.yaml
This is a proposal to refer NXmpes from NXarpes to avoid confusion for users of the definition.
This relates to #74 (i.e., whether it should refer to NXphotoemission or NXmpes).
It might also be a point for discussion whether NXarpes is a legacy version and newer experiments should be collected in NXmpes. Do we also support converting NXarpes to NXmpes/NXmpes_arpes?