-
Notifications
You must be signed in to change notification settings - Fork 9
modify current doc. #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: fairmat
Are you sure you want to change the base?
modify current doc. #372
Conversation
Reviewer's Guide by SourceryThis pull request modifies the documentation and structure of several NeXus definitions. It removes the Updated class diagram for NXspmclassDiagram
class NXspm {
+current: NX_NUMBER
+current_offset: NX_NUMBER
--
+current: The DC current between tip and sample.
--
+current: Current setpoint or target value of the tunneling current between tip and sample after applying bias voltage.
}
note for NXspm.current "Updated documentation for current field"
Updated class diagram for NXpiezo_config_spmclassDiagram
class NXpiezo_config_spm {
+calibration: NXcalibration
}
class NXcalibration {
+calibration_type: NX_CHAR
}
NXpiezo_config_spm -- NXcalibration : has a
note for NXpiezo_config_spm.calibration "Added documentation for calibration group"
Updated class diagram for NXstmclassDiagram
class NXstm {
-current: NX_NUMBER
+current_offset: NX_NUMBER
}
note for NXstm.current "Removed current field"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @RubelMozumder - I've reviewed your changes - here's some feedback:
Overall Comments:
- The SHA hash in the YAML files should be updated automatically by a script.
- The changes touch both the YAML and XML definitions - it would be good to keep these in sync.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@RubelMozumder sourcery is extremely verbose here, we should have a clean one liner that explains what this PR is about and which technique (spm, xps, etc.) it provides changes for, thank you |
Summary by Sourcery
Modify documentation for scanning probe microscopy (SPM) related YAML and NXDL files, focusing on current and calibration descriptions
Enhancements:
Documentation: