Skip to content

modify current doc. #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: fairmat
Choose a base branch
from
Open

Conversation

RubelMozumder
Copy link

@RubelMozumder RubelMozumder commented Apr 7, 2025

Summary by Sourcery

Modify documentation for scanning probe microscopy (SPM) related YAML and NXDL files, focusing on current and calibration descriptions

Enhancements:

  • Refine the description of current measurements to specify it as a setpoint or target value
  • Improve clarity of calibration documentation for piezo devices

Documentation:

  • Update documentation for current descriptions in NXstm and NXspm to clarify the meaning of current measurements
  • Add documentation for piezo device calibration in NXpiezo_config_spm

Copy link

sourcery-ai bot commented Apr 7, 2025

Reviewer's Guide by Sourcery

This pull request modifies the documentation and structure of several NeXus definitions. It removes the current field from NXstm, updates the documentation for the current field in NXspm, and adds documentation for the calibration group in NXpiezo_config_spm. Additionally, the SHA hashes in the YAML files have been updated to reflect these changes.

Updated class diagram for NXspm

classDiagram
    class NXspm {
        +current: NX_NUMBER
        +current_offset: NX_NUMBER
        --
        +current: The DC current between tip and sample.
        --
        +current: Current setpoint or target value of the tunneling current between tip and sample after applying bias voltage.
    }
    note for NXspm.current "Updated documentation for current field"
Loading

Updated class diagram for NXpiezo_config_spm

classDiagram
    class NXpiezo_config_spm {
        +calibration: NXcalibration
    }
    class NXcalibration {
        +calibration_type: NX_CHAR
    }
    NXpiezo_config_spm -- NXcalibration : has a
    note for NXpiezo_config_spm.calibration "Added documentation for calibration group"
Loading

Updated class diagram for NXstm

classDiagram
    class NXstm {
        -current: NX_NUMBER
        +current_offset: NX_NUMBER
    }
    note for NXstm.current "Removed current field"
Loading

File-Level Changes

Change Details Files
Removed the current field from the NXstm class.
  • Removed the current field and its documentation from the NXstm class in both the YAML and XML files.
contributed_definitions/nyaml/NXstm.yaml
contributed_definitions/NXstm.nxdl.xml
Updated the documentation of the current field in the NXspm class.
  • Modified the description of the current field in the NXspm class to specify that it represents the current setpoint or target value.
  • Updated the documentation in both the YAML and XML files.
contributed_definitions/nyaml/NXspm.yaml
contributed_definitions/NXspm.nxdl.xml
Added documentation for the calibration group in NXpiezo_config_spm.
  • Added a doc field to the calibration group in both the YAML and XML files to describe the calibration of the piezo device.
contributed_definitions/nyaml/NXpiezo_config_spm.yaml
contributed_definitions/NXpiezo_config_spm.nxdl.xml
Updated SHA hashes in definition files.
  • Updated the SHA hashes in the NXstm.yaml, NXspm.yaml, and NXpiezo_config_spm.yaml files to reflect the changes made to the files.
contributed_definitions/nyaml/NXstm.yaml
contributed_definitions/nyaml/NXspm.yaml
contributed_definitions/nyaml/NXpiezo_config_spm.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @RubelMozumder - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The SHA hash in the YAML files should be updated automatically by a script.
  • The changes touch both the YAML and XML definitions - it would be good to keep these in sync.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mkuehbach
Copy link
Collaborator

@RubelMozumder sourcery is extremely verbose here, we should have a clean one liner that explains what this PR is about and which technique (spm, xps, etc.) it provides changes for, thank you

@mkuehbach mkuehbach added the spm PRs related to research in the domain of scanning probe microscopy label Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spm PRs related to research in the domain of scanning probe microscopy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants