63 remove autoxrd schemas #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Pull Request Test Coverage Report for Build 14310112011Details
💛 - Coveralls |
ka-sarthak
force-pushed
the
63-remove-autoxrd-schemas
branch
from
d74cf33 to
9b00dbd
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR removes all AutoXRD-related code (schemas, models, apps, and example uploads) from the main repository in preparation for its re-implementation in the dedicated nomad-auto-xrd plugin.
- Removed AutoXRD schema definitions and normalization routines.
- Removed AutoXRD app and plugin entry point implementations.
- Updated pyproject.toml to remove AutoXRD-related entry points.
Reviewed Changes
Copilot reviewed 26 out of 39 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/nomad_analysis/example_uploads/init.py | Removed AutoXRD example upload entry point |
| src/nomad_analysis/auto_xrd/auto_xrd_analysis.py | Removed schema for AutoXRD analysis |
| src/nomad_analysis/auto_xrd/auto_xrd.py | Removed AutoXRD normalization and model schema |
| src/nomad_analysis/auto_xrd/init.py | Removed plugin entry point definitions for AutoXRD |
| src/nomad_analysis/apps/auto_xrd.py | Removed AutoXRD models app configuration |
| src/nomad_analysis/apps/init.py | Removed AutoXRD app entry point |
| pyproject.toml | Removed AutoXRD-related entry points |
Files not reviewed (13)
- src/nomad_analysis/example_uploads/auto_xrd/All_CIFs/AllCuxPXSx_CollCode22451.cif: Language not supported
- src/nomad_analysis/example_uploads/auto_xrd/All_CIFs/AllCuxPXSx_CollCode24530.cif: Language not supported
- src/nomad_analysis/example_uploads/auto_xrd/All_CIFs/AllCuxPXSx_CollCode29705.cif: Language not supported
- src/nomad_analysis/example_uploads/auto_xrd/All_CIFs/AllCuxPXSx_CollCode412240.cif: Language not supported
- src/nomad_analysis/example_uploads/auto_xrd/All_CIFs/AllCuxPXSx_CollCode430200.cif: Language not supported
- src/nomad_analysis/example_uploads/auto_xrd/All_CIFs/AllCuxPXSx_CollCode628635.cif: Language not supported
- src/nomad_analysis/example_uploads/auto_xrd/All_CIFs/AllCuxPXSx_CollCode628636.cif: Language not supported
- src/nomad_analysis/example_uploads/auto_xrd/All_CIFs/AllCuxPXSx_CollCode628639.cif: Language not supported
- src/nomad_analysis/example_uploads/auto_xrd/All_CIFs/AllCuxPXSx_CollCode656975.cif: Language not supported
- src/nomad_analysis/example_uploads/auto_xrd/All_CIFs/AllCuxPX_CollCode15056.cif: Language not supported
- src/nomad_analysis/example_uploads/auto_xrd/All_CIFs/AllCuxPX_CollCode16247.cif: Language not supported
- src/nomad_analysis/example_uploads/auto_xrd/All_CIFs/AllCuxPX_CollCode16841.cif: Language not supported
- src/nomad_analysis/example_uploads/auto_xrd/All_CIFs/AllCuxPX_CollCode198370.cif: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These will be implemented in
nomad-auto-xrdplugin