Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes for the nomad oasis september release and consolidation #152

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Bugfixes for the nomad oasis september release and consolidation #152

merged 4 commits into from
Sep 5, 2023

Conversation

mkuehbach
Copy link
Collaborator

…rrectly so that they can be picked up by Nomad

markus.kuehbach and others added 3 commits September 4, 2023 15:05
Add temporary fix to handle improper units Angstroms and degrees - co…
3a1d35f 
…rrectly so that they can be picked up by Nomad
@domna
Update definitions (#153)
6f6eed4 
* Update definitions

* Update regression tests

* Fix linting
Updating nxdefs which is the one to be used for all consolidation for…
d8cb313 
… the large nomad-oasis feature update via the consolidation branch update-north-markus
sanbrock
sanbrock approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@sanbrock sanbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkuehbach mkuehbach closed this Sep 5, 2023
@mkuehbach mkuehbach reopened this Sep 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Pull Request Test Coverage Report for Build 6086127611

  • 8 of 9 (88.89%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.05%) to 51.045%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pynxtools/dataconverter/readers/ellips/reader.py 5 6 83.33%
Files with Coverage Reduction New Missed Lines %
pynxtools/dataconverter/readers/shared/map_concepts/mapping_functors.py 1 11.86%
pynxtools/nyaml2nxdl/nyaml2nxdl_forward_tools.py 1 79.42%
tests/dataconverter/test_writer.py 1 96.77%
pynxtools/nexus/nxdl_utils.py 2 74.79%
Totals Coverage Status
Change from base Build 6085346763: -0.05%
Covered Lines: 5985
Relevant Lines: 11725
💛 - Coveralls

@mkuehbach mkuehbach merged commit 979ec9d into master Sep 5, 2023
4 checks passed
@mkuehbach mkuehbach mentioned this pull request Sep 5, 2023
Merged
@mkuehbach mkuehbach deleted the update-markus-north branch April 16, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanbrock sanbrock sanbrock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkuehbach @sanbrock @domna