Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds passing of objects to transmission reader #157

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

domna
Copy link
Collaborator

@domna domna commented Sep 12, 2023

This adds the functionality of passing a dict to the transmission readers convert function.

@hampusnasstrom

@sherjeelshabih
Copy link
Collaborator

So you pass Dict type objects and append them to the template? No other object types are accepted currently, right?

@coveralls
Copy link

coveralls commented Sep 12, 2023

Pull Request Test Coverage Report for Build 6160085524

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 51.07%

Files with Coverage Reduction New Missed Lines %
pynxtools/dataconverter/readers/rii_database/reader.py 2 94.44%
pynxtools/dataconverter/readers/utils.py 8 90.24%
Totals Coverage Status
Change from base Build 6086304081: -0.02%
Covered Lines: 5990
Relevant Lines: 11729

💛 - Coveralls

@domna
Copy link
Collaborator Author

domna commented Sep 12, 2023

So you pass Dict type objects and append them to the template? No other object types are accepted currently, right?

Exactly, I expect an iterable of dicts. Every other element is simply warned about and ignored

@domna domna merged commit 43d952f into master Sep 12, 2023
4 checks passed
@domna domna deleted the add-objects-to-transmission branch September 12, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants