replace BasicEln #451
Merged
replace BasicEln #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaspie
force-pushed
the
replace_BasicEln
branch
from
4ee1f74
to
be74186
Compare
…orage in quantities
lukaspie
force-pushed
the
replace_BasicEln
branch
from
a287b39
to
22f5d07
Compare
lukaspie
force-pushed
the
replace_BasicEln
branch
from
4800eca
to
2eafea5
Compare
lukaspie
reviewed
Oct 21, 2024
src/pynxtools/nomad/utils.py
Outdated
| @@ -72,6 +72,7 @@ def __rename_nx_for_nomad( | |||
|
|
|||
| if name and name.startswith("NX"): | |||
| name = __REPLACEMENT_FOR_NX + name[2:] | |||
| name = name[0].upper() + (name[1:] if len(name) > 1 else "") | |||
There was a problem hiding this comment.
Why not name = name[:1].upper() + name[1:]? I don't think we need the len check.
… m_set_attribute directly on the quantity
lukaspie
approved these changes
Oct 25, 2024
| @@ -36,7 +36,7 @@ jobs: | |||
| - name: Install nomad | |||
| if: "${{ matrix.python_version != '3.8' && matrix.python_version != '3.12'}}" | |||
| run: | | |||
| uv pip install nomad-lab@git+https://gitlab.mpcdf.mpg.de/nomad-lab/nomad-FAIR.git | |||
| uv pip install nomad-lab@git+https://gitlab.mpcdf.mpg.de/nomad-lab/nomad-FAIR.git@Sprint_Nomad_BaseSection | |||
There was a problem hiding this comment.
This shall eventually be reverted when the nomad branch is merged. We can do it here or later, as you wish.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.