Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for entry_type assignment #464

Merged
merged 2 commits into from
Nov 15, 2024
Merged

fix for entry_type assignment #464

merged 2 commits into from
Nov 15, 2024

Conversation

sanbrock
Copy link
Collaborator

No description provided.

lukaspie
lukaspie approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@lukaspie lukaspie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove print statements, other than that LGTM.

src/pynxtools/nomad/parser.py Outdated Show resolved Hide resolved
src/pynxtools/nomad/parser.py Outdated Show resolved Hide resolved
@sanbrock sanbrock merged commit a31431b into master Nov 15, 2024
14 checks passed
@lukaspie lukaspie deleted the entry_type branch November 15, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaspie lukaspie lukaspie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanbrock @lukaspie