Attempt at automatic typing for basix #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscroggs
force-pushed
the
jhale/automatic-typing
branch
from
60912b4
to
ae21675
Compare
|
I'm going to merge this, as having these types set is good and we can update manually for now. I've opened an issue for automating this: #536 |
|
@jhale what's the command for generating the stubs? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was created using mypy's automatic stub creator. I then replaced np.ndarray with npt.NDArray by automatic substitution.
In practice though it did not work in my nvim/pyright setup.
Can anyone else try it? It's not clear to me how this should be automated/updated either.