Skip to content

Re-enable Windows CI #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhale merged 5 commits into from
Jul 22, 2024
Merged

Re-enable Windows CI #845

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c982f38
Try using patched nanobind to build Basix.
jhale Jul 22, 2024
c2a3f87
Need setuptools and wheel for some dependencies.
jhale Jul 22, 2024
92c7535
Add missing build isolation.
jhale Jul 22, 2024
c76ef09
Reenable on all.
jhale Jul 22, 2024
bff6622
Update windows.yml
jhale Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions .github/workflows/windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,18 @@
name: Basix CI on Windows

on:
workflow_dispatch:
pull_request:
branches:
- main
push:
tags:
- "v*"
branches:
- main
merge_group:
branches:
- main
workflow_dispatch:

jobs:
build-combined:
Expand All @@ -24,10 +35,14 @@ jobs:
uses: actions/setup-python@v5
with:
python-version: "3.11"


- name: Install build dependencies (workaround)
run: |
python -m pip install scikit-build-core[pyproject] git+https://github.com/jhale/nanobind.git@jhale/msvc2022-workaround setuptools wheel
- name: Install Basix (combined)
run: |
python -m pip -v install --no-cache-dir .[ci] --config-settings=cmake.args=-DINSTALL_RUNTIME_DEPENDENCIES=ON --config-settings=cmake.args=-DCMAKE_TOOLCHAIN_FILE=C:/vcpkg/scripts/buildsystems/vcpkg.cmake
python -m pip -v install --no-build-isolation --no-cache-dir .[ci] --config-settings=cmake.args=-DINSTALL_RUNTIME_DEPENDENCIES=ON --config-settings=cmake.args=-DCMAKE_TOOLCHAIN_FILE=C:/vcpkg/scripts/buildsystems/vcpkg.cmake

- name: Run units tests
run: |
python -m pytest -n auto --durations 20 test/
Expand Down Expand Up @@ -68,10 +83,14 @@ jobs:
cmake --build build-dir --config Release
cmake --install build-dir --config Release --prefix D:/a/basix/install
echo "D:/a/basix/install/bin" | Out-File -Append -FilePath $env:GITHUB_PATH -Encoding utf8

- name: Install build dependencies (workaround)
run: |
python -m pip install scikit-build-core[pyproject] git+https://github.com/jhale/nanobind.git@jhale/msvc2022-workaround setuptools wheel
- name: Install Basix (Python)
run: |
cd python
python -m pip -v install --no-cache-dir .[ci] --config-settings=cmake.args=-DBasix_DIR=D:/a/basix/install/lib/cmake/basix
python -m pip -v install --no-build-isolation --no-cache-dir .[ci] --config-settings=cmake.args=-DBasix_DIR=D:/a/basix/install/lib/cmake/basix
cd ../

- name: Run units tests
Expand Down