Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TimeLogManager and make TimeLogger monostate #3494

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Remove TimeLogManager and make TimeLogger monostate #3494

wants to merge 5 commits into from

Conversation

schnellerhase
Copy link
Contributor

Fixes #3480

@schnellerhase schnellerhase marked this pull request as ready for review November 2, 2024 19:06
@garth-wells
Copy link
Member

What's the advantage of a monostate design over a singleton? Looks to me to all intents and purposes to be the same thing.

@schnellerhase
Copy link
Contributor Author

I think in this case it results in the same. We can decide on the interface we prefer, rather calling some kind of an instance function in the singleton approach or the constructor as here with the monostate.

@schnellerhase
Copy link
Contributor Author

Shall we stick to the monostate or return to the singleton approach, just within TimeLogger now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timer improvements
2 participants
@schnellerhase @garth-wells