Codim 2 coupling #731
Open
Codim 2 coupling #731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgensd
commented
Feb 23, 2025
mscroggs
reviewed
Feb 25, 2025
jorgensd
commented
Feb 25, 2025
|
Thank you very much to Dokken and all the developers. If it's not too much trouble, could you kindly provide just one usage example? As for the embedded ridge, it’s not yet available for use, correct? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces code-generation for 3D-1D/2D-0D coupling over "ridges" of a cell.
It follows the same path as the mixed dimensional assembly for 3D-2D/2D-1D as made by @jpdean.
Currently, we only support "exterior" ridge integrals, meaning integrals with a one-sided (cell) view of the ridge.
This is due to the lack of arbitrary restriction operators within UFL.
The code does not touch any of the DOLFINx functionality/API, which will be in a separate PR.
The PR also adds type hints in some appropriate places.